MehVahdJukaar / Supplementaries

Other
147 stars 107 forks source link

[1.18.2] Failing to break Skull piles and crash when breaking with quark's Pickerang wtih "Just Mob Heads" #507

Open Shibva opened 1 year ago

Shibva commented 1 year ago

Mod Version: 1.18.2 supplementaries-1.18.2-1.5.16.jar

issue: Possibly only present on a game server instance (non-singleplayer; server host) skull stakcs do not seem to fully break and create a issue of where the block still exists (but does not visually render on the players end until you look at the location; at the lest then an outline of it will appear)

The issue is circumvented when using a fakeplayer to break it (Create drills)

Secondary issue: using Quark's Pickerang on it will cause this message to appear Server thread/ERROR] [net.minecraftforge.eventbus.EventBus/EVENTBUS]: Exception caught during firing event: class net.mehvahdjukaar.supplementaries.common.block.tiles.DoubleSkullBlockTile cannot be cast to class net.minecraft.world.level.block.entity.SkullBlockEntity (net.mehvahdjukaar.supplementaries.common.block.tiles.DoubleSkullBlockTile is in module supplementaries@1.18.2-1.5.15 of loader 'TRANSFORMER' @430b2699; net.minecraft.world.level.block.entity.SkullBlockEntity is in module minecraft@1.18.2 of loader 'TRANSFORMER' @430b2699)

MehVahdJukaar commented 1 year ago

I need the whole log

Shibva commented 1 year ago

the second instance can be recreated by using a pickergang on a skull pile

I will need to talk tot he server host to grab that; see if you can recreate it on your end on SP

MehVahdJukaar commented 1 year ago

ok i'll give it a shot. Asked because last time something similar was reported it was caused by another mod

MehVahdJukaar commented 1 year ago

I cant replicate it. None of them. Tested on a server with quark

MehVahdJukaar commented 1 year ago

did this in 1.19 as thats active development branch but that part of the code didnt change from 1.18

Shibva commented 1 year ago

sorry for the long delay;

this was found in a modpack thats being worked on. Ill try to reproduce in on a SP server and if it crashes (hopefuly) I will be able to provide a complete crash report and game log if needed

Shibva commented 1 year ago

@MehVahdJukaar here you go; sorry for the long delay

thankfully I was able to reproduce this on a SP server

I would also like to note that the block "breaks" when you try to break it but it doesn't break (the box still exist but the render does not on the client end)

https://gist.github.com/Shibva/33b55f25377d726696ad571330f2de5f

Shibva commented 1 year ago

image I bring this up because I feel that it may be related to this bug

MehVahdJukaar commented 1 year ago

Unsafe cast and error from justmobheads

Shibva commented 1 year ago

I have a theory on what might be going on

In the mod there, is a behavior where drop heads and mob heads are broken if they are player skulls will automatically be renamed. So if you break one of these player skulls generated they are renamed if they are custom player head made to represent a mob. For example, breaking a villager head you get from a drop will drop the skull but renamed to Villager instead of Player Head

I have a feeling that something about this process is interfering wtih the skull piles, hence why its also extending to regular skulls as well (in terms of the double skull pile in the presence of "just mob heads" causing this issue wtih the skull piles to affect ALL skulls)

On another note regarding the issue with the pickergand and skull stacks being unbreakable wtihout creative assistence I do have something of note: Using the drill block from the mod Create is capable of breaking the stack pile

hopefully a fix can be found and again sorry for the delay between responses ^w^

Shibva commented 1 year ago

Renamed issue for clarity now that its identified and made a report on the other end in case its only a fix that can be done on their end and for documentation/notification purposes

Its likely that this issue will exist in versions past 18.2 though I have not confirmed this at this time

If you need more information please let me know and ill get back ASAP ^w^

MehVahdJukaar commented 1 year ago

So the issue is on their side as they are making some unsafe assumption (head == vanilla head). Idk about the other issue you say you have. I can't replicate it, I can break those just fine creative or not.

Shibva commented 1 year ago

thats odd, the mods in the pack being used had this issue when I tested it in survival even in singleplayer (regarding the heads not breaking properly at all)

This pack im using thankfully is one that's posted on CurseForge and is not a large one (under 50 if not under 100 mods).

Download the latest version of the mod pack below and test around with that. You should encounter the issue then https://beta.curseforge.com/minecraft/modpacks/create-technical-4-alpha/files/4460712

Hope this helps; if I need to I will also upload a video of the second issue in question ^w^

EDIT: pack contains the latest versions of Supplementary as of 4/1/2023 EDIT 2: The date of this comment post; and no this is not an elaborate April 1st joke. IMO doing something like that would just be disrespectful of someones time.