MehVahdJukaar / labels-multi

Other
1 stars 8 forks source link

Labels disappearing #33

Open Quietlee opened 1 year ago

Quietlee commented 1 year ago

I'm not sure why this hasn't been fixed yet as it's obviously a common complaint.

If I TP away or log out and back in again the labels are still attached but there is nothing on them. Other players can see them up until they log out or travel away.

I am not using Optifine. I'm on Fabric 1.20.1. This is not an entity culling issue as players on my server can have hundreds of item frames in one chunk with no issue.

Any chance you're able to fix this issue? If the labels disappear completely (At least visually anyway) whenever you walk away from them it makes the mod completely broken. I noticed that people were having this issue over a year ago, are you able to fix it or should we give up hope at this point?

It's a great mod, it would be a shame if it ended up being completely useless.

MehVahdJukaar commented 1 year ago

I heard somebody say it's a shader issue

MehVahdJukaar commented 1 year ago

But if that's the case it's a completely different form them not appearing for client which took me ages to identify and has definitely been fixed

Quietlee commented 1 year ago

I've tried the shader thing (I noticed someone else with complimentary shaders had the same problem) but even without them installed it happens so it's definitely not been fixed I'm afraid. I saw others still posting recently having the same issue. Is it not fixable on your end?

On Thu, 31 Aug 2023, 14:59 MehVahdJukaar, @.***> wrote:

I heard somebody say it's a shader issue

— Reply to this email directly, view it on GitHub https://github.com/MehVahdJukaar/labels-multi/issues/33#issuecomment-1701093695, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASOCC6VLZT3DYADSPMPS5F3XYCKEVANCNFSM6AAAAAA4FT6QHQ . You are receiving this because you authored the thread.Message ID: @.***>

MehVahdJukaar commented 1 year ago

i have no idea. As ive said its not the issue that was previously plaguing this mod. that has been finally solved. whatever this is is about the label dynamic texture not being initialized properly instead. Howeve unfortunatelly, just like other issue i cant replicate this. for other ones it only appeared in certain chunks or some other weird condition which tbh i never tracked down and just fixed the issue at the root by rewtiting most of the code to not use item frame logic. For this ill too need to first have a way to replicate. First of all check if the labels have lost their item or as im assuming are just not generating their texture properly by using /data get entity on them

chonkyman commented 1 year ago

I'm also having this issue Fabric 1.20.1 Mod Version 1.1.6

Wilevar commented 11 months ago

I can third this. I manage a small personal modpack and run it on a server. Whenever I log back in the labels I've placed on chests are still present, but blank.

I'll see if I can replicate it on SP, and if so I'll try slowly adding back mods to see if there's some particular conflict. Maybe an optimization mod or something (Lithium for example) might be causing data loss on the labels.

MC Version: 1.20.1 Mod Version: 1.16 Fabric Version: 0.14.22

Wilevar commented 11 months ago

I've been able to duplicate it in Single Player as well. Modpack "Mystic Wilds"

Going to now disable all mods but Storage Labels, and see if the problem goes away, then start adding mods back in till it happens again.

Wilevar commented 11 months ago

Ok, so it seems whatever's causing the issue might affect the world itself. Here are my steps and results so far:

  1. I made a world with 199 mods, confirmed the issue was happening by making a set of double-chests, crafting labels from paper, placing 2 labels on the fronts of each double chest, using standard minecraft items to put the pictures on the labels (Stick, Wood Log, Sappling, Flower), exiting the world, then immediately going back in. Labels blank.
  2. Exited minecraft, disabled all mods, Except Moonlight, Fabric API, and Labels. (see image)
  3. Restarted minecraft, loaded the same world, re-applied images to the labels, exited the world, and re-entered the world. Labels blank.

All Mods Disabled

Now I'm going to leave everything as-is, with only your Moonlight and Labels enabled, and make a new world. See if the same happens.

Wilevar commented 11 months ago

New world, loaded with only those mods enabled above, the same issue occurred. Labels went blank after leaving the world and coming back.

Also, they won't accept seeds as an image, apparently. o.o

Let me know if there's anything else I can do to help troubleshoot, but I've just eliminated all mods in my pack as potential conflicts, short of completely re-installing minecraft to a different directory.

MehVahdJukaar commented 10 months ago

wait so this is a fabric only issue?

MehVahdJukaar commented 10 months ago

Yeah still cant replicate not even once.

DcNdrew commented 8 months ago

It's still happening. labels-1.20-1.19-fabric

corbinpenguin commented 8 months ago

I am also having this issue in quilt 1.20.1

However, I am using complementary-euphoria shaders which may be involved?

fluffyxox commented 7 months ago

@MehVahdJukaar Have you still been unable to replicate it as of yet? The exact versions I've used to replicate are:

Game version 1.20.1 Loader Version 0.15.6 Fabric API 0.91.0+1.20.1 Moonlight Lib fabric_1.20-2.8.84 Storage Labels 1.20-1.19

No other additions, fresh Modrinth profile Place a label, fill it, save and quit, return to blank label

MehVahdJukaar commented 7 months ago

I kind of gave up on this tbh. I know it's fabric only issue due to spawn packet that happens randomly, possibly due to synced entity data. Even after 2 band aid fix of forcefully sending that stuff over it still doesn't work idk what to do

fluffyxox commented 7 months ago

Dang, unfortunate.