search

Mehdi-Rh / Portfolio_Microverse

This portfolio website was build during the Microverse Bootcamp.
12 stars 0 forks source link

Morning session peer review #8

Open i-max-xi opened 2 years ago

i-max-xi commented 2 years ago

Discuss a few changes and other requirements that were missed

Mehdi-Rh commented 2 years ago

For the HTML part, when a class is unique for only one session, the best is to put an id instead of a class.

i-max-xi commented 2 years ago

The "right" property could only be used when the "position : absolute" property is included. Refer to the link below to access the inline comment https://github.com/Mehdi-Rh/Portfolio_Microverse/pull/4#discussion_r786468409

It may be a better idea to exclude it or add the "position: absolute" to effect the "right" property

Yoz21 commented 2 years ago

No need for the Readme acknowledgment section. The descriptions or mentions of acknowledgments are unnecessary.