search

Melapress / admin-notices-manager

Admin notices manager is a WordPress plugin that allows you to better manage the admin notices in the WordPress dashboard so you read them at your own convenience and never miss an important message.
https://www.wpwhitesecurity.com/wordpress-plugins/admin-notices-manager/
Other
0 stars 0 forks source link

better handling of plugin update? #46

Closed robert81 closed 3 years ago

robert81 commented 3 years ago

When I try to install a version of a plugin that is already installed on the website, WordPress gives me the following option, even if it is the same version:

image

However, if I do this with ANM I get the following errors:

image

It seems like we are not using the "built-in updating process"?

DannyWPWS commented 3 years ago

@robert81 The "do you want to replace the current with uploaded" check only happens when the plugin directories are identical, so in the case of ANM if you where to upload a new version with the same file structure as your installed version, you will get the same result.

The oppose it also true, so in the case of 2FA if you upload a version which doesnt 100% match the folder name, WP will allow it to activate as normal and you get the same kind of "already defined" errors on screen

image

I will however pop a little check in place so ANM does not attempt to redefine these constants however just in case a user does so happen to put themselves in this position