Meldexun / RenderLib

7 stars 1 forks source link

[Workaround in comments] OpenGL debugging is incompatible with CleanroomMC-0.2.2 #47

Open Delfite opened 3 months ago

Delfite commented 3 months ago

Disclaimer: If applicable please set the openGLDebugOutput -> enabled config option from RenderLib to true and try to reproduce the issue.

Describe the bug

Attempting to load RenderLib 1.3.5 via CleanroomMC on Java 21 or Java 22 causes a game crash. No Nothirium for me :(

Reproducibility

Please try to reproduce the issue with as few other mods as possible. Then check one of the following checkboxes according to your results. To check a checkbox replace the space between the square brackets with an x (like this [x]) or create the issue and check the checkbox by clicking on it.

To Reproduce

Steps to reproduce the behavior. Please keep in mind that I most likely don't know how other mods involved in this issue work. Thus terms like "Go to dimension X" should be explained in more detail because I probably don't know how to do that.

  1. Install CleanroomMC-0.2.2-alpha (Current latest build) 1a. I used the MultiMC instance option since I use Prism Launcher 8.4, but from what I know the installers should function identically to my setup.
  2. Install RenderLib 1.3.5 (Current latest release)
  3. Install MixinBootstrap 1.1.0 (Current latest release)
  4. Launch the game
  5. Game should crash immediately after the game window appears

Screenshots/Videos

If applicable, add screenshots or videos to help explain your problem. N/A

Versions

RenderLib: 1.3.5 Forge: Technically N/A but I'm assuming Cleanroom is based off of 14.23.5.2860 since that makes the most sense to base it off of Minecraft: 1.12.2 Other mods (necessary to reproduce the bug): CleanroomMC-0.2.2-alpha (linked in the "To Reproduce" section)

Hardware

CPU: Ryzen 5-2600 @ 3.4GHz RAM: 2x8GB @ 3200MHz GPU: ASUS TUF GAMING GTX 1660 SUPER VRAM: 6GB

Log File

Providing a log file is always necessary no matter if the game crashed or not. This also means that the crash report is not needed. Please use a paste site to upload the log file (for example https://gist.github.com/) and provide the link to the file here.

This log was recorded while using the Java 22.0.2.9 Runtime Environment provided by Adoptium. Changing my Java version does not fix the issue.

Latest.log

Additional Notes

I am not expecting you to fix this, mainly because your mod was developed for Forge, not Cleanroom. My primary reason for making this report is to 1. Document the issue and 2. Hopefully encourage someone to fork your mod and turn it into something that works with Cleanroom, since Nothirium provides insane performance gains and I'd love to see it on a more modern modding framework like Cleanroom (especially since Vintagium's development seems to have halted as of recent, effectively meaning I have no way of getting optimized chunk rendering on Cleanroom without cutting corners).

Also, you should really make each section title as headers by default instead of just bold text. I've noticed it helps make reports look nicer and much easier to read.

Meldexun commented 2 months ago

Looks like Cleanroom removes some LWJGL things. I can't really fix this on my end.

But you can disable the OpenGL debugging in the RenderLib config as a workaround.

Delfite commented 2 months ago

But you can disable the OpenGL debugging in the RenderLib config as a workaround.

Hey, it worked! Do you mind adding a "workaround found" tag to this issue so people know to check the comments? I'm sure it'd save people a lot of headache of having to diagnose the issue themselves. image