Mellanox / sockperf

Network Benchmarking Utility
Other
597 stars 119 forks source link

issue: 2935075 For windows CI and compilation #201

Closed EldarShalev closed 2 years ago

EldarShalev commented 2 years ago

There was a mismatch between macro definitions which caused a warning compilations-level error

C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\ucrt\inttypes.h(117,1): error C2220: the following warning is treated as an error [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\ucrt\inttypes.h(117,1): warning C4005: 'PRId64': macro redefinition [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

c:\Jenkins\workspace\sockperf-windows\src\os_abstract.h(61): message : see previous definition of 'PRId64' [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

C:\Program Files (x86)\Windows Kits\10\Include\10.0.19041.0\ucrt\inttypes.h(174,1): warning C4005: 'PRIu64': macro redefinition [c:\Jenkins\workspace\sockperf-windows\win\project\sockperf.vcxproj]

old definitions is not necessary anymore therefor is deleted

swx-jenkins3 commented 2 years ago

Can one of the admins verify this patch?

vasily-v-ryabov commented 2 years ago

bot:retest

vasily-v-ryabov commented 2 years ago

bot:retest

vasily-v-ryabov commented 2 years ago

bot:retest

vasily-v-ryabov commented 2 years ago

Windows CI is successful with this PR: http://hpc-master.lab.mtl.com:8080/job/sockperf-windows/7/console

igor-ivanov commented 2 years ago

@EldarShalev please follow issue: xxx Commit message format

EldarShalev commented 2 years ago

@EldarShalev please follow issue: xxx Commit message format

what is the issue number?

agalanin-at-nvidia commented 2 years ago

bot:retest

agalanin-at-nvidia commented 2 years ago

bot:retest

vasily-v-ryabov commented 2 years ago

Windows build is OK: http://hpc-master.lab.mtl.com:8080/job/sockperf-windows/8/console

igor-ivanov commented 2 years ago

@EldarShalev please follow issue: xxx Commit message format

what is the issue number?

I guess you could use [2935075]

igor-ivanov commented 2 years ago

bot:retest

vasily-v-ryabov commented 2 years ago

bot:retest