search

MeltanoLabs / tap-salesforce

Singer.io tap for the Salesforce API
GNU Affero General Public License v3.0
1 stars 30 forks source link

base64 is set to be a character type and not binary anymore #32

Closed Bartman0 closed 1 year ago

Bartman0 commented 2 years ago

base64 data is character based on its own. it may represent binary data, but that's not the issue here: base64 data can perfectly well be loaded as character data.

pnadolny13 commented 1 year ago

@dan-ladd do you have any thoughts on this PR? It might have gotten lost in the mix, I didnt see it until now.

dan-ladd commented 1 year ago

Confirmed that handling as a string is fine here. byte may actually be fine, too.

Thanks for the PR @Bartman0 and thanks for the nudge @pnadolny13