MeltanoLabs / tap-salesforce

Singer.io tap for the Salesforce API
GNU Affero General Public License v3.0
1 stars 30 forks source link

Tap Salesforce - Installed version issue #7

Closed MeltyBot closed 2 years ago

MeltyBot commented 5 years ago

Migrated from GitLab: https://gitlab.com/meltano/tap-salesforce/-/issues/7

Originally created by @aaronsteers on 2019-11-09 21:42:46


Somehow I've gotten a version of this tap (1.4.29) which is not documented anywhere and appears to be further ahead in the version id, while being behind in the code base. I was getting error messages about required argments that didn't look like they should be required. When I finally opened up tap_salesforce/__init__.py on my local machine I found that it has several more fields in REQUIRED_CONFIG_KEYS than are listed under the master branch here: https://gitlab.com/meltano/tap-salesforce/blob/master/tap_salesforce/__init__.py#L24

I then forced an install for pip install 'tap-salesforce==1.4.25' (the latest version mentioned in release notes) and the REQUIRED_CONFIG_KEYS still does not match master.

REQUIRED_CONFIG_KEYS = ['refresh_token',
                        'client_id',
                        'client_secret',
                        'start_date',
                        'api_type',
                        'select_fields_by_default']

CONFIG = {
    'refresh_token': None,
    'client_id': None,
    'client_secret': None,
    'start_date': None
}

Whereas the master branch only has two required args. I'm pausing on trying to debug auth issues (Issue #6) while I try to confirm I have the latest/greatest stable version.

Any assist/direction is much appreciated.

MeltyBot commented 2 years ago

View 7 previous comments from the original issue on GitLab