Docker support - Githubissues

MenuDocs / Mandroc

https://trello.com/b/BGqujXcO/mandroc-development

GNU General Public License v3.0

10 stars 5 forks source link

Docker support #24

Open duncte123 opened 3 years ago

duncte123 commented 3 years ago

Mandroc will need to run on docker when finished, here are some requirements for that

must use multi-stage building (separating the fetching of the dependencies from the running)
must use docker-compose version 3.7
must publish own docker image
must use env variables in docker-compose
must be tested in docker before deploying to the server
should use a volume for data persistence
could have support for both .env files and docker-compose env vars
won't automatically reboot on crash (docker configuration)

viztea commented 3 years ago

^ pls do docker-compose file ant.

I'm not confident I can create a working one. I've made the bot able to read from a JSON file and environment variables, I assume "docker-compose env vars" is just environment variables?

duncte123 commented 3 years ago

I've made the bot able to read from a JSON file and environment variables,

I cannot upload this file to the container, also it gets a new container on every restart. Env variables is the best way.

I assume "docker-compose env vars" is just environment variables?

yes that are just env variables, but they are in the containers env and not in a .env file

I'm not confident I can create a working one.

Don't worry, install docker on your computer and it yell at you when something is wrong. Also here's an example https://github.com/DuncteBot/SkyBot/blob/master/docker-compose.yml (yes this is different from a Dockerfile I can help with that one if needed)

viztea commented 3 years ago

I've made the bot able to read from a JSON file and environment variables,

I cannot upload this file to the container, also it gets a new container on every restart. Env variables is the best way

I know, I was just stating I had already implemented a fallback incase the config file wasn't found.

I assume "docker-compose env vars" is just environment variables?

yes that are just env variables, but they are in the containers env and not in a .env file

I'm not confident I can create a working one.

Don't worry, install docker on your computer and it yell at you when something is wrong. Also here's an example https://github.com/DuncteBot/SkyBot/blob/master/docker-compose.yml (yes this is different from a Dockerfile I can help with that one if needed)

I've created a docker-compose file for my bot, was just getting annoyed lolol