Closed uclaros closed 4 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
input/app/projectsmodel.cpp | 1 | 65.75% | ||
input/app/inpututils.cpp | 306 | 51.51% | ||
<!-- | Total: | 307 | --> |
Totals | |
---|---|
Change from base Build 8628227245: | -0.04% |
Covered Lines: | 7580 |
Relevant Lines: | 12629 |
What's also not used any more is the considerMapExtentOffset
parameter in
function centerToPair( pair, considerMapExtentOffset = false ) {
if ( considerMapExtentOffset )
var mapExtentOffsetRatio = mapExtentOffset / mapCanvas.height
else
mapExtentOffsetRatio = 0
__inputUtils.setExtentToFeature( pair, mapCanvas.mapSettings, mapExtentOffsetRatio )
}
and the relevant code in InputUtils::setExtentToFeature()
Should I remove those?
What's also not used any more is the
considerMapExtentOffset
parameter infunction centerToPair( pair, considerMapExtentOffset = false ) { if ( considerMapExtentOffset ) var mapExtentOffsetRatio = mapExtentOffset / mapCanvas.height else mapExtentOffsetRatio = 0 __inputUtils.setExtentToFeature( pair, mapCanvas.mapSettings, mapExtentOffsetRatio ) }
and the relevant code in
InputUtils::setExtentToFeature()
Should I remove those?
Sure, if it is not used anymore, let's remove it
Fixes #3260