MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
292 stars 64 forks source link

Fix offline issues in Projects page with no/expired token #3326

Closed wonder-sk closed 4 months ago

wonder-sk commented 4 months ago
  1. incorrect "no workspace detected" message
  2. endless busy wait on the home tab (unable to switch projects)
  3. endless loop of requesting projects in the second tab

The hasAuthData() function is confusing - one may think it returns whether we are logged in, but in fact it only tells whether username+password have been set.

Before:

https://github.com/MerginMaps/mobile/assets/193367/3976e964-ff10-4ae4-89fc-a8c946cdfac6

After:

https://github.com/MerginMaps/mobile/assets/193367/2e65f78f-3244-41f9-a4a1-bef432ea1618

github-actions[bot] commented 4 months ago

Pull Request Test Coverage Report for Build 8722278224

Details


Files with Coverage Reduction New Missed Lines %
input/app/projectsproxymodel.h 1 0.0%
input/app/projectsmodel.h 2 25.0%
input/core/project.h 2 55.56%
input/app/projectwizard.cpp 20 2.94%
input/app/projectsproxymodel.cpp 38 0.0%
input/app/projectsmodel.cpp 65 65.75%
input/app/mmstyle.h 66 2.02%
<!-- Total: 194 -->
Totals Coverage Status
Change from base Build 8721422835: -0.3%
Covered Lines: 7582
Relevant Lines: 12635

💛 - Coveralls