search

Merott / nativescript-pdf-view

A basic PDF viewer plugin for NativeScript. Now maintained by @madmas: github.com/madmas/nativescript-pdf-view
Other
32 stars 35 forks source link

Bump the Android native library in order to fix a crash with certain PDFs #40

Closed EddyVerbruggen closed 5 years ago

EddyVerbruggen commented 5 years ago

Hi!

Long time fan (and user) of your plugin!

Today we found this particular PDF crashes the app when loaded: https://loopmein-dev.imgix.net/vehicle-documents/d21fcae0-85be-4577-8ee5-d5452c9c1255.pdf

The reason is unknown, the only thing we know is it's fixed by bumping the native Android library to the latest version of the 2.x branch. Somewhere in between 2.5.1 and 2.8.2 this crash was fixed by the author.

While I was in the gradle file I also switched compile to implementation, since that's the recommended way to load libraries in gradle these days.

Also added .vscode to .npmignore because it has no business in the npm package.

Thanks a lot for considering merging this, and it would be awesome if you can publish a new version to npm as well!

Merott commented 5 years ago

Hey there @EddyVerbruggen - thanks for your PR, and sorry I haven't been quite attentive to this package, with lots of other commitments these days.

Merging now.

EddyVerbruggen commented 5 years ago

Hey @Merott, that's how things go sometimes, I know all about it. Thanks for merging this so quickly, really looking forward to adding this fix to my projects. Good luck with all your commitments! 👍