Mesabrook-Development-Team / Immersibrook

Immersibrook is a super special mod developed for use on the Mesabrook modded Minecraft server.
https://mesabrook.com
GNU General Public License v3.0
4 stars 2 forks source link

Crash When Leaving Conference Call #47

Closed CSX8600 closed 2 years ago

CSX8600 commented 2 years ago

Server crash when leaving conference call when at least one player involved has disconnected (possible theory)

https://pastebin.com/vMcu4rfh

RavenholmZombie commented 2 years ago
// Hi. I'm Minecraft, and I'm a crashaholic.

Time: 8/8/22 11:02 PM
Description: Exception in server tick loop

java.lang.NullPointerException: Exception in server tick loop
    at com.mesabrook.ib.telecom.CallManager.tick(CallManager.java:112)
    at com.mesabrook.ib.telecom.handlers.ServerTickEventHandler.onTick(ServerTickEventHandler.java:22)
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_122_ServerTickEventHandler_onTick_ServerTickEvent.invoke(.dynamic)
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
    at net.minecraftforge.fml.common.FMLCommonHandler.onPostServerTick(FMLCommonHandler.java:266)
    at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:712)
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)
    at java.lang.Thread.run(Thread.java:748)

I think your theory may be correct.

CSX8600 commented 2 years ago

Actually it looks like it might be because I never considered how to handle logging conference calls in the call history log

https://github.com/RavenholmZombie/Immersibrook/blob/ea788e8cd42a01f6db9bd178228f18d7665838f0/src/main/java/com/mesabrook/ib/telecom/CallManager.java#L112

CSX8600 commented 2 years ago

This needs to be reopened - this issue is still present.

RavenholmZombie commented 2 years ago

Repoened

CSX8600 commented 2 years ago

Can't replicate. Carefully documented steps will be required before this can be closed.