MeshJS / mesh

TypeScript open-source library to advance Web3 development on Cardano
https://meshjs.dev
Apache License 2.0
221 stars 65 forks source link

Account index and key index fix in MeshWallet #396

Closed d-Bharti001 closed 5 days ago

d-Bharti001 commented 5 days ago

Summary

MeshWallet is targeted to have the ability to access an account at any index generated from an HD mnemonic (or a root private key). But it was not able to access any account other than the first one.

  1. After rearranging some lines of code, MeshWallet is now able to utilize the provided accountIndex and keyIndex when an instance is created, which was not the case before, because getAddressesFromWallet() was getting called before setting those indexes.
  2. In MeshWallet's signData(), the accountIndex and keyIndex are now being passed to the EmbeddedWallet's signData().

Affect components

Please indicate which part of the Mesh Repo

Type of Change

Related Issues

Not any

Checklist

Please ensure that your pull request meets the following criteria:

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mesh-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2024 8:00pm
vercel[bot] commented 5 days ago

Someone is attempting to deploy a commit to the MeshJS Team on Vercel.

A member of the Team first needs to authorize it.