Mesnage-Org / pgfinder

Peptidoglycan MS1 Analysis Tool
https://mesnage-org.github.io/pgfinder
GNU Lesser General Public License v3.0
4 stars 2 forks source link

[pre-commit.ci] pre-commit automatically updated. #250

Closed pre-commit-ci[bot] closed 5 months ago

pre-commit-ci[bot] commented 7 months ago

updates:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9fe6948) 69.37% compared to head (fd9cb64) 69.37%.

:exclamation: Current head fd9cb64 differs from pull request most recent head 0b56685. Consider uploading reports for the commit 0b56685 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #250 +/- ## ======================================= Coverage 69.37% 69.37% ======================================= Files 11 11 Lines 493 493 ======================================= Hits 342 342 Misses 151 151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ns-rse commented 7 months ago

For some reason one of the playwright tests is failing again, any idea why @TheLostLambda

TheLostLambda commented 7 months ago

For some reason one of the playwright tests is failing again, any idea why @TheLostLambda

I'd guess it's because I've gotten lazy about merging that other PR! That's the issue with the current PyPi system I mentioned... The 1.1.0 is published on PyPi (as it has to be for the CI tests to use that version), then I fixed the tests in that PR.

Since I've not gotten around to adding the tests and merging it though, the tests will fail until that's merged! That PR also pins the PyPi version though, so we shouldn't have this problem in the future, theoretically!

TheLostLambda commented 7 months ago

Here is looks like the tests are going a good job and picking up on the fact the new 1.1.0 is exposing new modification options and some of the previous ones have gone!