search

MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients
MIT License
293 stars 188 forks source link

Release 236.0.0 #4870

Closed bergeron closed 3 weeks ago

bergeron commented 3 weeks ago

This is intended to release the asset controllers. I also included other controllers the release tool thought should be included

bergeron commented 3 weeks ago

I'm considering simplifying this by just releasing assets-controllers, and intentionally skipping other packages. If anyone can help verify it's safe to do so.

FrederikBolding commented 3 weeks ago

@bergeron Can we release controller-utils as part of this as well?

bergeron commented 3 weeks ago

Major version bumps in peer dependencies are always breaking changes, and should be recorded in the changelogs. Non-major bumps in peer dependencies should not be applied at all in the package.json peerDependencies section nor in the changelog. Updating the devDependencies entry is still necessary.

Version bumps applied by this PR should also be added to the changelogs.

Can you explain how this is different from what's in the PR? I'm just running the release tool and categorizing each entry it puts in the changelog. Is there something additional to do on top?

bergeron commented 3 weeks ago

The only potential breaking changes in these changelogs are the major version bumps for @metamask/utils and @metamask/eth-sig-util

I wasn't sure how to determine whether these were breaking, so errred on the side of major release. But can mark that as breaking in changelog unless someone can say they're not breaking.

Looking deeper into the changes I think they're both non breaking for consumers