MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients
MIT License
293 stars 188 forks source link

refactor: remove global network from transaction controller #4920

Open matthewwalsh0 opened 1 week ago

matthewwalsh0 commented 1 week ago

Explanation

Remove all global network usage from the @metamask/transaction-controller package.

Specifically:

References

Changelog

See CHANGELOG.md.

Checklist

matthewwalsh0 commented 1 week ago

@metamaskbot publish-preview

github-actions[bot] commented 1 week ago

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. ``` { "@metamask-previews/accounts-controller": "19.0.0-preview-e6757fdb", "@metamask-previews/address-book-controller": "6.0.1-preview-e6757fdb", "@metamask-previews/announcement-controller": "7.0.1-preview-e6757fdb", "@metamask-previews/approval-controller": "7.1.1-preview-e6757fdb", "@metamask-previews/assets-controllers": "43.0.0-preview-e6757fdb", "@metamask-previews/base-controller": "7.0.2-preview-e6757fdb", "@metamask-previews/build-utils": "3.0.1-preview-e6757fdb", "@metamask-previews/chain-controller": "0.1.3-preview-e6757fdb", "@metamask-previews/composable-controller": "9.0.1-preview-e6757fdb", "@metamask-previews/controller-utils": "11.4.3-preview-e6757fdb", "@metamask-previews/ens-controller": "15.0.0-preview-e6757fdb", "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-e6757fdb", "@metamask-previews/gas-fee-controller": "22.0.1-preview-e6757fdb", "@metamask-previews/json-rpc-engine": "10.0.1-preview-e6757fdb", "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-e6757fdb", "@metamask-previews/keyring-controller": "18.0.0-preview-e6757fdb", "@metamask-previews/logging-controller": "6.0.2-preview-e6757fdb", "@metamask-previews/message-manager": "11.0.1-preview-e6757fdb", "@metamask-previews/multichain": "0.0.0-preview-e6757fdb", "@metamask-previews/name-controller": "8.0.1-preview-e6757fdb", "@metamask-previews/network-controller": "22.0.2-preview-e6757fdb", "@metamask-previews/notification-controller": "7.0.0-preview-e6757fdb", "@metamask-previews/notification-services-controller": "0.13.0-preview-e6757fdb", "@metamask-previews/permission-controller": "11.0.3-preview-e6757fdb", "@metamask-previews/permission-log-controller": "3.0.1-preview-e6757fdb", "@metamask-previews/phishing-controller": "12.3.0-preview-e6757fdb", "@metamask-previews/polling-controller": "12.0.1-preview-e6757fdb", "@metamask-previews/preferences-controller": "14.0.0-preview-e6757fdb", "@metamask-previews/profile-sync-controller": "1.0.0-preview-e6757fdb", "@metamask-previews/queued-request-controller": "7.0.1-preview-e6757fdb", "@metamask-previews/rate-limit-controller": "6.0.1-preview-e6757fdb", "@metamask-previews/selected-network-controller": "19.0.0-preview-e6757fdb", "@metamask-previews/signature-controller": "22.0.0-preview-e6757fdb", "@metamask-previews/transaction-controller": "39.0.0-preview-e6757fdb", "@metamask-previews/user-operation-controller": "18.0.0-preview-e6757fdb" } ```
matthewwalsh0 commented 1 week ago

@metamaskbot publish-preview

github-actions[bot] commented 1 week ago

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. ``` { "@metamask-previews/accounts-controller": "19.0.0-preview-49553b36", "@metamask-previews/address-book-controller": "6.0.1-preview-49553b36", "@metamask-previews/announcement-controller": "7.0.1-preview-49553b36", "@metamask-previews/approval-controller": "7.1.1-preview-49553b36", "@metamask-previews/assets-controllers": "43.0.0-preview-49553b36", "@metamask-previews/base-controller": "7.0.2-preview-49553b36", "@metamask-previews/build-utils": "3.0.1-preview-49553b36", "@metamask-previews/chain-controller": "0.1.3-preview-49553b36", "@metamask-previews/composable-controller": "9.0.1-preview-49553b36", "@metamask-previews/controller-utils": "11.4.3-preview-49553b36", "@metamask-previews/ens-controller": "15.0.0-preview-49553b36", "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-49553b36", "@metamask-previews/gas-fee-controller": "22.0.1-preview-49553b36", "@metamask-previews/json-rpc-engine": "10.0.1-preview-49553b36", "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-49553b36", "@metamask-previews/keyring-controller": "18.0.0-preview-49553b36", "@metamask-previews/logging-controller": "6.0.2-preview-49553b36", "@metamask-previews/message-manager": "11.0.1-preview-49553b36", "@metamask-previews/multichain": "0.0.0-preview-49553b36", "@metamask-previews/name-controller": "8.0.1-preview-49553b36", "@metamask-previews/network-controller": "22.0.2-preview-49553b36", "@metamask-previews/notification-controller": "7.0.0-preview-49553b36", "@metamask-previews/notification-services-controller": "0.13.0-preview-49553b36", "@metamask-previews/permission-controller": "11.0.3-preview-49553b36", "@metamask-previews/permission-log-controller": "3.0.1-preview-49553b36", "@metamask-previews/phishing-controller": "12.3.0-preview-49553b36", "@metamask-previews/polling-controller": "12.0.1-preview-49553b36", "@metamask-previews/preferences-controller": "14.0.0-preview-49553b36", "@metamask-previews/profile-sync-controller": "1.0.0-preview-49553b36", "@metamask-previews/queued-request-controller": "7.0.1-preview-49553b36", "@metamask-previews/rate-limit-controller": "6.0.1-preview-49553b36", "@metamask-previews/selected-network-controller": "19.0.0-preview-49553b36", "@metamask-previews/signature-controller": "22.0.0-preview-49553b36", "@metamask-previews/transaction-controller": "39.0.0-preview-49553b36", "@metamask-previews/user-operation-controller": "18.0.0-preview-49553b36" } ```
matthewwalsh0 commented 1 week ago

@metamaskbot publish-preview

github-actions[bot] commented 1 week ago

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. ``` { "@metamask-previews/accounts-controller": "19.0.0-preview-913113cf", "@metamask-previews/address-book-controller": "6.0.1-preview-913113cf", "@metamask-previews/announcement-controller": "7.0.1-preview-913113cf", "@metamask-previews/approval-controller": "7.1.1-preview-913113cf", "@metamask-previews/assets-controllers": "43.0.0-preview-913113cf", "@metamask-previews/base-controller": "7.0.2-preview-913113cf", "@metamask-previews/build-utils": "3.0.1-preview-913113cf", "@metamask-previews/chain-controller": "0.1.3-preview-913113cf", "@metamask-previews/composable-controller": "9.0.1-preview-913113cf", "@metamask-previews/controller-utils": "11.4.3-preview-913113cf", "@metamask-previews/ens-controller": "15.0.0-preview-913113cf", "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-913113cf", "@metamask-previews/gas-fee-controller": "22.0.1-preview-913113cf", "@metamask-previews/json-rpc-engine": "10.0.1-preview-913113cf", "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-913113cf", "@metamask-previews/keyring-controller": "18.0.0-preview-913113cf", "@metamask-previews/logging-controller": "6.0.2-preview-913113cf", "@metamask-previews/message-manager": "11.0.1-preview-913113cf", "@metamask-previews/multichain": "0.0.0-preview-913113cf", "@metamask-previews/name-controller": "8.0.1-preview-913113cf", "@metamask-previews/network-controller": "22.0.2-preview-913113cf", "@metamask-previews/notification-controller": "7.0.0-preview-913113cf", "@metamask-previews/notification-services-controller": "0.13.0-preview-913113cf", "@metamask-previews/permission-controller": "11.0.3-preview-913113cf", "@metamask-previews/permission-log-controller": "3.0.1-preview-913113cf", "@metamask-previews/phishing-controller": "12.3.0-preview-913113cf", "@metamask-previews/polling-controller": "12.0.1-preview-913113cf", "@metamask-previews/preferences-controller": "14.0.0-preview-913113cf", "@metamask-previews/profile-sync-controller": "1.0.0-preview-913113cf", "@metamask-previews/queued-request-controller": "7.0.1-preview-913113cf", "@metamask-previews/rate-limit-controller": "6.0.1-preview-913113cf", "@metamask-previews/selected-network-controller": "19.0.0-preview-913113cf", "@metamask-previews/signature-controller": "22.0.0-preview-913113cf", "@metamask-previews/transaction-controller": "39.0.0-preview-913113cf", "@metamask-previews/user-operation-controller": "18.0.0-preview-913113cf" } ```
matthewwalsh0 commented 3 days ago

@metamaskbot publish-preview

github-actions[bot] commented 3 days ago

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions. ``` { "@metamask-previews/accounts-controller": "19.0.0-preview-14d3599e", "@metamask-previews/address-book-controller": "6.0.1-preview-14d3599e", "@metamask-previews/announcement-controller": "7.0.1-preview-14d3599e", "@metamask-previews/approval-controller": "7.1.1-preview-14d3599e", "@metamask-previews/assets-controllers": "43.0.0-preview-14d3599e", "@metamask-previews/base-controller": "7.0.2-preview-14d3599e", "@metamask-previews/build-utils": "3.0.1-preview-14d3599e", "@metamask-previews/chain-controller": "0.1.3-preview-14d3599e", "@metamask-previews/composable-controller": "9.0.1-preview-14d3599e", "@metamask-previews/controller-utils": "11.4.3-preview-14d3599e", "@metamask-previews/ens-controller": "15.0.0-preview-14d3599e", "@metamask-previews/eth-json-rpc-provider": "4.1.6-preview-14d3599e", "@metamask-previews/gas-fee-controller": "22.0.1-preview-14d3599e", "@metamask-previews/json-rpc-engine": "10.0.1-preview-14d3599e", "@metamask-previews/json-rpc-middleware-stream": "8.0.5-preview-14d3599e", "@metamask-previews/keyring-controller": "18.0.0-preview-14d3599e", "@metamask-previews/logging-controller": "6.0.2-preview-14d3599e", "@metamask-previews/message-manager": "11.0.1-preview-14d3599e", "@metamask-previews/multichain": "0.0.0-preview-14d3599e", "@metamask-previews/name-controller": "8.0.1-preview-14d3599e", "@metamask-previews/network-controller": "22.0.2-preview-14d3599e", "@metamask-previews/notification-controller": "7.0.0-preview-14d3599e", "@metamask-previews/notification-services-controller": "0.13.0-preview-14d3599e", "@metamask-previews/permission-controller": "11.0.3-preview-14d3599e", "@metamask-previews/permission-log-controller": "3.0.1-preview-14d3599e", "@metamask-previews/phishing-controller": "12.3.0-preview-14d3599e", "@metamask-previews/polling-controller": "12.0.1-preview-14d3599e", "@metamask-previews/preferences-controller": "14.0.0-preview-14d3599e", "@metamask-previews/profile-sync-controller": "1.0.0-preview-14d3599e", "@metamask-previews/queued-request-controller": "7.0.1-preview-14d3599e", "@metamask-previews/rate-limit-controller": "6.0.1-preview-14d3599e", "@metamask-previews/selected-network-controller": "19.0.0-preview-14d3599e", "@metamask-previews/signature-controller": "22.0.0-preview-14d3599e", "@metamask-previews/transaction-controller": "39.0.0-preview-14d3599e", "@metamask-previews/user-operation-controller": "18.0.0-preview-14d3599e" } ```