feat: add well formed `eip155` reference value check to `multichain` package - Githubissues

MetaMask / core

This monorepo is a collection of packages used across multiple MetaMask clients

MIT License

293 stars 188 forks source link

feat: add well formed `eip155` reference value check to `multichain` package #4945

Closed jiexi closed 3 days ago

jiexi commented 3 days ago

Explanation

Fixes bug where 0 prefixed and e exponent suffixed eip155 references were allowed. This PR adds eip155 reference validation against regex.

I'm unsure if this belongs in validation checks, or the supported checks. Validation checks currently do not check for ecosystem specific constraints

References

Changelog

Package has not been released yet. No changelog necessary

Checklist

[ ] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
[ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes