search

MetaMask / eth-json-rpc-middleware

Ethereum middleware for composing an Ethereum provider using json-rpc-engine. Intended to replace provider-engine
ISC License
179 stars 88 forks source link

Changes in typed signature validation and normalization #318

Closed jpuri closed 1 month ago

jpuri commented 2 months ago

The PR addresses these 2 issues:

https://github.com/MetaMask/metamask-extension/issues/25733 https://github.com/MetaMask/MetaMask-planning/issues/2810

mcmire commented 2 months ago

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

legobeat commented 2 months ago

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

Saw this in other repos when rerunning previously passing jobs. Also specifically Node 22.

Node.js 22.5.0 was just released so maybe something lurking here?

Unless it's simply an intermittent infra issue at GH.

cryptodev-2s commented 2 months ago

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

Saw this in other repos when rerunning previously passing jobs. Also specifically Node 22.

Node.js 22.5.0 was just released so maybe something lurking here?

Unless it's simply an intermittent infra issue at GH.

Oof, I see that CI is failing. This could be either a problem where the cache is not being properly restored, or the incorrect set of files is being saved in the cache. In other repos we've discussed replacing yarn --immutable --immutable-cache with yarn --immutable in .github/workflows/build-lint-test.yml. I'll try to investigate soon, but you could experimenting with that if you're stuck.

Saw this in other repos when rerunning previously passing jobs. Also specifically Node 22.

Node.js 22.5.0 was just released so maybe something lurking here?

Unless it's simply an intermittent infra issue at GH.

@legobeat a fix for this has just been included in a new node patch v22.5.1

mcmire commented 2 months ago

I've fixed the Node issue here: https://github.com/MetaMask/eth-json-rpc-middleware/pull/321