search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.93k forks source link

Investigate bundle size increased caused by #15878 #16269

Open danjm opened 2 years ago

danjm commented 2 years ago

https://github.com/MetaMask/metamask-extension/pull/15878 aimed to decrease the bundle size, but ended up increasing it.

We need to investigate to understand why this happened, and then try to reverse the bundle size increase

danjm commented 1 year ago

@adonesky1 @mikesposito Was this ever resolved? I seem to remember a PR or github ticket being created in response to this, but not sure where to find

mikesposito commented 1 year ago

@danjm the bundle size increase was due to an additional @ethereumjs/util's major version in the dependency tree. This should be the resulting ticket: #16534