search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

[Bug]: Multi RPC - network notification doesn't appear consistently #25788

Open sleepytanya opened 4 months ago

sleepytanya commented 4 months ago

Describe the bug

The 'You're now using ***' modal pops up for certain networks, and this behavior appears to be most consistent with a fresh install. If a user removes a network and then re-adds it, the notification doesn't seem to reappear.

Sometimes the network popup appears for the short time and then automatically closes (related bug https://github.com/MetaMask/metamask-extension/issues/25196).

Expected behavior

-

Screenshots/Recordings

https://github.com/user-attachments/assets/ca1b5c20-c2bf-48e8-b48f-b1e79bdedd3b

Steps to reproduce

  1. Connect Popular networks on fresh MM install
  2. Switch between networks
  3. Notice that the notifications appears for some of the networks

Error messages or log output

No response

Version

Multi PRC build

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

bergeron commented 1 month ago

I think this is an existing bug unrelated to multi RPCs. But there is something to improve. This NewNetworkInfo component is meant to show when you switch to a network for the first time. It appears immediately for the first network. But for subsequent switches it only appears after a refresh or close/open of the popup

https://github.com/user-attachments/assets/020985fa-f29d-45db-86be-6328fead8e88