search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.83k stars 4.82k forks source link

ERC 1155 support for crypto items #5887

Open EtherDotBlue opened 5 years ago

EtherDotBlue commented 5 years ago

Related to: Display individual collectibles #5230

danimesq commented 5 years ago

@alextsg @frankiebee @tmashuang @danfinlay

crisgarner commented 5 years ago

Now that the status of the ERC 1155 is final, support for this wouldn't benefit only games but also other types of applications https://github.com/ethereum/eips/issues/1155

C0deMunk33 commented 4 years ago

I would love to see this happen as well

danfinlay commented 4 years ago

We are definitely aware of this EIP and are planning to support it.

vporton commented 4 years ago

But what should be the UI in practice? As far as I understand, there is its own set of tokens for each deployed ERC-1155 contract. (Right?)

So, need a UI feature to add a new ERC-1155 contract address to the wallet and for each token we need to display two numbers: token ID and its contract address.

Is transferring tokens between two different ERC-1155 contract addresses possible?

C0deMunk33 commented 4 years ago

Make a list of tokens under a heading of the contract name or address. Take the "TransferSingle" and "TransferBatch" events with the user address and then query "balanceOf"/"balanceOfBatch" with the returned _id/_ids to get all the current balances of tokens the account holds.

As for the metadata, parse the contents of "URI" event for each _id/_ids for a .gif or .png etc and common 'name' values and display those along with the balance itself.

https://github.com/enjin/erc-1155/blob/master/contracts/IERC1155.sol

On Tue, Nov 26, 2019 at 12:25 PM Victor Porton notifications@github.com wrote:

But what should be the UI in practice? As far as I understand, there is its own set of tokens for each deployed ERC-1155 contract. (Right?)

So, need a UI feature to add a new ERC-1155 contract address to the wallet and for each token we need to display two numbers: token ID and its contract address.

Is transferring tokens between two different ERC-1155 contract addresses possible?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/5887?email_source=notifications&email_token=ADFGN7LUDGWBMSWGTT7LAHTQVWA25A5CNFSM4GIWLO5KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHKP6I#issuecomment-558802937, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFGN7LLHXYVM6UJMUYPCXLQVWA25ANCNFSM4GIWLO5A .

litvinof commented 4 years ago

Would you consider reviewing a PR to support the current standards of NFTs? (ERC-721, ERC-1155) Would it make sense to put effort into it? Or you've already been working on this?

danfinlay commented 4 years ago

We already have this on our backlog, and should be implementing a solution soon.

In the longer future, we intend to unblock new standards from integration via our plugin system.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.174 ETH (24.87 USD @ $142.94/ETH) attached to it as part of the 1155ERCorp fund.

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 0.474 ETH (67.75 USD @ $142.94/ETH) .

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 8 months, 2 weeks from now. Please review their action plans below:

1) sanchaymittal has been approved to start work.

Will work as per the requirements.

Learn more on the Gitcoin Issue Details page.

sanchaymittal commented 4 years ago

Hi @everyone, I will be working on this issue. I need some more details or requirements. Can we arrange a call anytime soon.

sanchaymittal commented 4 years ago

Hi @EtherDotBlue, Can you provide me with some more details.

EtherDotBlue commented 4 years ago

@sanchaymittal here is the EIP: https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1155.md and here 8s the reference implementation from Enjin: https://github.com/enjin/erc-1155

KiChjang commented 4 years ago

Has this issue been actively worked on? Or can any contributor apply for it?

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 0.924 ETH (241.07 USD @ $260.9/ETH) .

danfinlay commented 4 years ago

Please note @sanchaymittal and @kichjang that this bounty was not posted by the MetaMask team, and we are already planning on implementing this ourselves, with our own design team. The odds of implementing this in a way that is compatible with our current plans is low. I'll be reaching out to GitCoin to see if we can prevent people from posting bounties on issues that we aren't ready to open to bounty hunting.

KiChjang commented 4 years ago

@danfinlay That was what I feared; there is a significant UI/UX design element associated with this issue, and I wasn't sure if it was suitable for an individual contributor to make design decisions without consensus with the development team. Thanks for letting me know!

vs77bb commented 4 years ago

@danfinlay @KiChjang Per request from Dan, I've hidden this issue on Gitcoin. @sanchaymittal -- please do hold off on implementation. Good luck to the MetaMask team on the implementation!

gitcoinbot commented 4 years ago

Issue Status: 1. Open 2. Cancelled

The funding of 0.924 ETH (210.38 USD @ $227.68/ETH) attached to this issue has been cancelled by the bounty submitter

kosecki123 commented 4 years ago

@danfinlay is there any update on when this could be available in the MetaMask?

The reason why asking is that ERC1155, in fact ERC1888 that extends it, is used by our project https://github.com/energywebfoundation/origin as a base standard for issuing RECs, and MetaMask support would allow us give our users a way to manage theirs tokens directly.

Ping me if there is anything we can help with to make it happen.

trilloc commented 4 years ago

hi team, any update on this please. cheers

gdanilo67 commented 4 years ago

@danfinlay I'm thinking to use ERC 1155 for tokenized vaucher and MetaMask support would be great! Can you update us on development status and release date? Thanks in advance, D.

C0deMunk33 commented 4 years ago

I, too, would like to see this exist, there's a bunch of uses for 1155s that are being developed at the moment.

On Wed, Aug 26, 2020 at 1:51 PM gdanilo67 notifications@github.com wrote:

@danfinlay https://github.com/danfinlay I'm thinking to use ERC 1155 for tokenized vaucher and MetaMask support would be great! Can you update us on development status and release date? Thanks in advance, D.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/5887#issuecomment-681117024, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFGN7OL6MFPZGYGSUHNRDTSCVYVJANCNFSM4GIWLO5A .

mcchan1 commented 3 years ago

Now that OpenZeppelin has released their 1155 token.... +1 for support of fractionalized NFTs. Art, real estate, game items, etc.

C0deMunk33 commented 3 years ago

Yeah I've been fractionalizing 721s into 1155s recently, I'd like to see 1155 support (finally)

On Fri, Sep 18, 2020, 7:37 AM mcchan1 notifications@github.com wrote:

Now that OpenZeppelin has released their 1155 token.... +1 for support of fractionalized NFTs. Art, real estate, game items, etc.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/5887#issuecomment-694906969, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFGN7LIW4BXKC4ISKJIU4LSGNWB7ANCNFSM4GIWLO5A .

FiveDreams commented 3 years ago

is it already available?

tbayan commented 3 years ago

Hi guys, are there any updates regarding the Metamask ERC1155 implementation?

greenfan commented 3 years ago

We're also using 1155 for our token and would like to see ERC1155 support in metamask

nnnnicholas commented 3 years ago

+1 for 1155 support in MetaMask 🚀

C0deMunk33 commented 3 years ago

Ideally I would like to see something based on this: ERC-1155 Metadata URI JSON Schema https://eips.ethereum.org/EIPS/eip-1155#metadata like this: [image: image.png] I understand it's much harder than it sounds, and my placement is bad, but I hope you get the idea.

On Tue, Feb 2, 2021 at 4:57 PM Nicholas notifications@github.com wrote:

+1 for 1155 support in MetaMask 🚀

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/5887#issuecomment-772123458, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFGN7MSKIEZ4YQXFAHFDUTS5CNPHANCNFSM4GIWLO5A .

quaekr commented 3 years ago

This has been in the backlog for years, any updates?

kiknaio commented 3 years ago

Any update here? Seems the issue is open for quite a while.

0x366 commented 3 years ago

Any updates? Or it's completely abandoned?

This not so different to ERC721 in terms of functionality - just change function call names and that's it. Why is it's taking 3 years and still no any updates?

greenfan commented 3 years ago

This should be prioritized and developed as we are in the hottest period for adoption and NFT's this is holding ethereum and ERC1155 back.

rkliss commented 2 years ago

@danfinlay can you give us an update on what's happening with this??

longdt commented 2 years ago

+1

a13z commented 2 years ago

+1

greenfan commented 2 years ago

+2

shaft3796 commented 2 years ago

+3

danimesq commented 2 years ago

With the merge of MyCrypto wallet, probably they will not exclude the support for NFTs.

kevinghim commented 2 years ago

Support for ERC-1155 along with ERC-721 will be coming to MetaMask extension in the next couple of releases.

greenfan commented 2 years ago

That's incredible news. I can continue developing my reputation project +1

danimesq commented 2 years ago

AFAIK, MetaMask Mobile does already support NFTs.

As both the desktop extension and the mobile app are written in ReactJS, probably there's no much difficulty in keeping the codebases of both synced/on-pair with one another.

justfish09 commented 1 year ago

Support for ERC-1155 along with ERC-721 will be coming to MetaMask extension in the next couple of releases.

@kevinghim how is this progressing? 🙏