chore: Cherry pick 2506358 (merge in trackEvent work)

kylanhurt commented 4 days ago

[!IMPORTANT] The issue is due to the fact that MetaMetrics.trackEvent method has multiple signatures to handle the backward compatibility with old ways to call it. After discussion (see the change history of this description), we decided to remove backward compatibility and the multiple signature system. We are going to simplify and then fix all the trackEvent calls. Asside from the changes in MetaMetrics and useMetrics hook (and tests) all the changes should be on the calls of trackEvent.

removes multiple signature MetaMetrics.trackEvent
updates MetaMetrics unit tests
updates useMetrics hook
updates useMetrics hook unit tests
deletes now useless legacy compatibility utils
updates all trackEvent calls
updates all unit tests that test trackEvent calls

Fixes #12117

navigate the app
check trackEvent is called (check app logs)

https://github.com/user-attachments/assets/058f6607-eda1-4eb5-bcae-a774deb13648

https://github.com/user-attachments/assets/fa0816cf-5459-4825-a162-a9a2e87c86ac

N/A

[x] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[x] I've completed the PR template to the best of my ability
[x] I’ve included tests if applicable
[x] I’ve documented my code using JSDoc format if applicable
[x] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

[ ] I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
[ ] I've completed the PR template to the best of my ability
[ ] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 4 days ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] commented 4 days ago

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 30a2c9f2e757c038fce1fcaca9d63feae2abdd6a Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/55b34ba5-2d62-4554-8e57-7f4494532f5b

[!NOTE]

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

Check the documentation if you have any doubts on how to understand the failure on bitrise