The assets-controllers can be updated independently to version ^9.0.0.
We will need to rebuild the patch manually, we can follow up the changes made on this core branch, that represents the assets-controllers on the earliest version.
The NFTController now has a new watchNFT method that can be called to send a message to the ApprovalController and prompt the user to add an NFT to their wallet state.
The NFTController now requires an instance of a ControllerMessenger to be passed to its constructor. This is messenger is used to pass the watchNFT message to the ApprovalController.
Scenario
No response
Design
No response
Technical Details
Upgrade assets-controllers to v^9.0.0
Re-build the patch of assets-controllers
Add messenger prop to the NftController initialization on Engine file
Threat Modeling Framework
No response
Acceptance Criteria
[ ] All old features remain working as expected
[ ] Assets-controller upgrade to version ^9.0.0
[ ] Links to bitrise E2E test pipeline are added to the ticket description
[ ] Ensure that all scenarios have passed.
Stakeholder review needed before the work gets merged
[X] Engineering (needed in most cases)
[ ] Design
[ ] Product
[X] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
What is this about?
The assets-controllers can be updated independently to version ^9.0.0.
We will need to rebuild the patch manually, we can follow up the changes made on this core branch, that represents the assets-controllers on the earliest version.
The files that were changed were:
Breaking Changes
Scenario
No response
Design
No response
Technical Details
NftController
initialization on Engine fileThreat Modeling Framework
No response
Acceptance Criteria
Stakeholder review needed before the work gets merged
References