MetaMask / metamask-sdk

The simplest yet most secure way to connect your blockchain-based applications to millions of MetaMask Wallet users.
https://metamask.io/sdk/
Other
188 stars 115 forks source link

feat: event alignment with async protocol #1054

Closed abretonc7s closed 1 month ago

abretonc7s commented 1 month ago

Explanation

This PR attempt to start cleaning up event emission while using async key exchange.

References

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 51.42857% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (570fba2) to head (5f331b8). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rvice/ConnectionManager/handleJoinChannelResult.ts 0.00% 7 Missing :warning:
...teCommunication/ConnectionManager/rejectChannel.ts 50.00% 4 Missing :warning:
...ketService/EventListeners/handleChannelRejected.ts 42.85% 4 Missing :warning:
...emoteCommunication/ConnectionManager/disconnect.ts 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1054 +/- ## ========================================== - Coverage 78.34% 78.16% -0.19% ========================================== Files 179 179 Lines 4146 4153 +7 Branches 1022 1020 -2 ========================================== - Hits 3248 3246 -2 - Misses 898 907 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.