search

MetaMask / snaps

Extend the functionality of MetaMask using Snaps
https://metamask.io/snaps/
Other
712 stars 547 forks source link

Make `local:` snap locations be actual URIs #1041

Open ritave opened 1 year ago

ritave commented 1 year ago

Right now local: locations look like this: local:http://localhost/, which is not a valid URI.

We should try to normalise Snap Locations to all be URIs and make them look like this: local://localhost/, or even better - just http://localhost/ with restrictions on hostname.

Context:

  1. https://github.com/MetaMask/snaps-monorepo/pull/1019#discussion_r1039523629
  2. SIP-8
Montoya commented 1 year ago

Is this necessary for v1?

ritave commented 1 year ago

It's a cosmetic change, I'm fine with leaving it out for v1 and supporting the old way as well as the new one