search

Meteor-Community-Packages / meteor-mocha

A Mocha test driver package for Meteor 1.3+. This package reports server AND client test results in the server console and can be used for running tests on a CI server or locally.
https://packosphere.com/meteortesting/mocha
MIT License
67 stars 40 forks source link

fix: Reload client side tests 2 #120

Closed jirikrepl closed 1 year ago

jirikrepl commented 3 years ago

this PR fix the lint errors of this PR https://github.com/Meteor-Community-Packages/meteor-mocha/pull/106

After my use (8+ months) as a local package with this PR https://github.com/Meteor-Community-Packages/meteor-mocha/pull/106 I think it is good to merge as-is.

Client-side tests are reloaded correctly with this PR 95% time. Without this PR client-side tests are not reloaded at all. Rarely (5%) Chrome would crash when watching client tests, and mocha would need to be restarted.

jirikrepl commented 3 years ago

Hi @StorytellerCZ what do you think?

jankapunkt commented 3 years ago

@jirikrepl just some questions for testing it - do you run your tests in the browser or do you do headless testing with puppeteer or similar? Just want to focus on the modes you don't use.

Regarding 5% - what means "crash" ? Freezing? Or just doing nothing? Error messages?

jirikrepl commented 3 years ago

I am running client tests in headless mode with puppeteer. That 5% cases print some error about browser crash, but I am not sure. I would post it here when I see it again