Metron-Project / metron-tagger

Command line tool to tag comic archives with metadata from Metron Comic Book Database.
https://metron.cloud/
GNU General Public License v3.0
23 stars 1 forks source link

Add option to skip multiple matchs that require user intervention #144

Open morsok opened 2 months ago

morsok commented 2 months ago

Describe the bug A clear and concise description of what the bug is.

With only the -o option I expected that it would never hang and ask things interactively. If it needed input without the -i flag I expect it to say can't find a match, run with -i next time

To Reproduce Steps to reproduce the behavior:

metron-tagger --online my-comic.cbz

Expected behavior A clear and concise description of what you expected to happen.

If it needed input without the -i flag I expect it to say can't find a match, run with -i next time

Screenshots If applicable, add screenshots to help explain your problem.

image
bpepple commented 2 months ago

That's the expected behavior, since our common use-case is the user wants to tag the comics with one call. And the interactive flag is used when the user wants to approve all matchs (in particular for TPB which a lot of the time have the same cover as an individual issue) in a session

What you're describing is more a power-user use-case where they are running it in a terminal multiplexer or background command, which currently isn't supported. It's simple enough to implement (probably a total for 5 lines over 3 python modules). The toughest thing about it would what flag to use for it.

I'll look at adding it, but not sure when I'll get some free time to do it.