search

Mic92 / nixos-shell

Spawns lightweight nixos vms in a shell
MIT License
685 stars 39 forks source link

Support `extendModules` for injecting nixos-shell's options and config modules #58

Closed tomeon closed 1 year ago

tomeon commented 2 years ago

This changeset makes it possible for folks on a recent-enough nixpkgs to use nixos-shell without declaring their system configs with lib.makeOverridable. Basically, this nixos-generators PR, except:

  1. This PR does not remove support for nixpkgs prior to the commit that introduced extendModules, and
  2. This PR also adds code to issue a fairly detailed error message in case the caller provides a system config that lacks both the override and extendModules attributes.

Thank you for your consideration.

Radvendii commented 1 year ago

This is essential for greatly simplifies my client's workflow, which also uses colmena for deployments. For now I'm just using the PR branch, but it would be nice to get it merged.

Mic92 commented 1 year ago

Thanks for testing bors merge

bors[bot] commented 1 year ago

Configuration problem: bors.toml: not found

Mic92 commented 1 year ago

https://github.com/Mic92/nixos-shell/releases/tag/1.1.0