Mic92 / nixos-shell

Spawns lightweight nixos vms in a shell
MIT License
685 stars 39 forks source link

fix: vm-forward example #68

Closed brianmcgee closed 1 year ago

brianmcgee commented 1 year ago

lib.mkForce is required

Closes #59

Jaculabilis commented 1 year ago

After getting this error and finding the issues here, I tried both mkForce and @fleaz's solution from #51 using virtualisation.forwardPorts. Both worked for what I tested, but I think the latter is a more user-friendly fix, since it uses existing NixOS options instead of the more heavy-handed mkForce.

brianmcgee commented 1 year ago

After getting this error and finding the issues here, I tried both mkForce and @fleaz's solution from #51 using virtualisation.forwardPorts. Both worked for what I tested, but I think the latter is a more user-friendly fix, since it uses existing NixOS options instead of the more heavy-handed mkForce.

virtualisation.forwardPorts is a much better approach. I've updated the example and the README to reflect this.

Mic92 commented 1 year ago

bors merge

Mic92 commented 1 year ago

Thx!