search

MichaelKim / ag-grid-svelte

A Svelte wrapper for ag-grid
https://ag-grid-svelte.michael.kim/guide
MIT License
49 stars 15 forks source link

Svelte 4 #14

Open brandonp-ais opened 1 year ago

brandonp-ais commented 1 year ago

Support Svelte 4

peerDependencies is using svelte 3.

See the Svelte migration guide

Reproduce

"svelte": "^4.0.5", "ag-grid-community": "^30.0.3", "ag-grid-svelte": "^0.3.0",

Then npm i

Error

Installation error npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: accessit-10-frontend@0.0.1 npm ERR! Found: svelte@4.0.5 npm ERR! node_modules/svelte npm ERR! dev svelte@"^4.0.5" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer svelte@"^3" from ag-grid-svelte@0.3.0 npm ERR! node_modules/ag-grid-svelte npm ERR! ag-grid-svelte@"^0.3.0" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
ngacho commented 1 month ago

Is there a reason why this migration hasn't been completed yet? I see there's a PR with a WIP, but it hasn't been completed.

If any please let me know I'm happy to try and look into it and try to resolve the issues

mlawlerau commented 1 month ago

I would like to see svelte 4 support too.