MicrosoftDocs / WindowsCommunityToolkitDocs

Creative Commons Attribution 4.0 International
179 stars 156 forks source link

[BrokenLinksH2] Fixed the link path #621

Closed v-sidlama closed 2 years ago

v-sidlama commented 2 years ago

Fixing the links

opbld33 commented 2 years ago

Docs Build status updates of commit cd7498d:

:warning: Validation status: warnings

File Status Preview URL Details
dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml :warning:Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/TokenizingTextBox.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/Carousel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/CarouselItem.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/DropShadowPanel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/GridSplitter.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/BladeView.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/EyedropperToolButton.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/Menu.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/ImageCropper.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/InfiniteCanvas.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGauge.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/MenuItem.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGaugeAutomationPeer.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls.TextToolbarButtons/DefaultButton.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapPanel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapLayout.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBoxStyleSelector.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TabbedCommandBarItemTemplateSelector.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/UniformGrid.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBox.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredPanel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredLayout.xml :warning:Warning View Details

This comment lists only the first 25 files in the pull request.

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml

dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

opbld30 commented 2 years ago

Docs Build status updates of commit 5c2799e:

:warning: Validation status: warnings

File Status Preview URL Details
dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml :warning:Warning View Details
dotnet/xml/Microsoft.Toolkit.Uwp.UI.Controls/TokenizingTextBox.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/CarouselItem.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/DropShadowPanel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/EyedropperToolButton.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/BladeView.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/ImageCropper.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/GridSplitter.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/InfiniteCanvas.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGauge.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/Carousel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredPanel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/MenuItem.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/DockPanel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/UniformGrid.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TabbedCommandBarItemTemplateSelector.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/RadialGaugeAutomationPeer.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBox.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapPanel.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/WrapLayout.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls.TextToolbarButtons/DefaultButton.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/TokenizingTextBoxStyleSelector.xml :warning:Warning View Details
dotnet/xml/CommunityToolkit.WinUI.UI.Controls/StaggeredLayout.xml :warning:Warning View Details

This comment lists only the first 25 files in the pull request.

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/UserToPersonConverter.xml

dotnet/xml/CommunityToolkit.Graph.Uwp.Converters/ObjectToStringConverter.xml

dotnet/xml/CommunityToolkit.Graph.Uwp.Controls/PeoplePicker.xml

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request. For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

v-sidlama commented 2 years ago

Global effort to fix broken links

@nmetulev

The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This source page contains several broken links related to HamburgerMenu. And we couldn't find the articles it should link to. However, it might be an archived content. Pease review within five business days and let us know how to proceed further or comment in the PR with any changes you'd like to see. Thanks!

nmetulev commented 2 years ago

@michael-hawker should take a look at this

tfosmark commented 2 years ago

@v-sidlama I see only one typo fix in your PR, but many other link issues are flagged...

v-sidlama commented 2 years ago

@v-sidlama I see only one typo fix in your PR, but many other link issues are flagged...

Yes, that's why this is parked on a Draft and I left a comment to the author. Please see above. Thank You!

v-sidlama commented 2 years ago

Global effort to fix broken links

@michael-hawker

The Content & Learning team is fixing broken links on docs.microsoft.com for the rest of H2. This effort will eliminate potential accessibility, security, and usability issues. This source page contains several broken links related to HamburgerMenu. And we couldn't find the articles it should link to. However, it might be an archived content. Pease review within five business days and let us know how to proceed further or comment in the PR with any changes you'd like to see. Thanks!

michael-hawker commented 2 years ago

@v-sidlama all the validation warnings are from the generated docs, there may be something going on with the linkages there to the API browser. I'm not sure. Shouldn't be an issue towards the change made itself.

However, everything in the archive directory is just old documentation we moved there for legacy purposes. Is there some metadata item we can add to the top of the file to better indicate this?

v-sidlama commented 2 years ago

@v-sidlama all the validation warnings are from the generated docs, there may be something going on with the linkages there to the API browser. I'm not sure. Shouldn't be an issue towards the change made itself.

However, everything in the archive directory is just old documentation we moved there for legacy purposes. Is there some metadata item we can add to the top of the file to better indicate this?

Metadata is out of our scope. Please let us know how to check this off on our end. Thank you!

michael-hawker commented 2 years ago

@v-sidlama I'm not asking about validating metadata, I'm asking if there's a flag we can add on these archival documents to get them ignored by the link checking tool. Or is there another process we should follow to mark docs as deprecated/out-dated?

tfosmark commented 2 years ago

@michael-hawker We have seen some teams put in a comment that the files should not be updated as they are considered archive.

We can update our team tracker to note this repo contains autogenerated content and that there's archived content. Thanks for the context!

michael-hawker commented 2 years ago

@tfosmark yeah, this repo is going to not exist in about 3-6 months. We're in the process of splitting out our auto-generated content to a separate repo and moving content to a different repo as well. We're also hoping to audit all our current docs that we generate for consistency as we refactor our codebase.