search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.2k stars 21.34k forks source link

AKS Learn feedback: Explain why to specify nobrl in mountOptions of statically provisioned PersistentVolume #123601

Open mloskot opened 2 months ago

mloskot commented 2 months ago

Type of issue

Missing information

Feedback

The PV example in the Statically provision a volume section displays the following mount options:

  mountOptions:
    - dir_mode=0777
    - file_mode=0777
    - uid=0
    - gid=0
    - mfsymlinks
    - cache=strict
    - nosharesock
    - nobrl

but there is no explanation on why the nobrl is needed or recomended?

The current official example in the azurefile-csi-driver repository does not present use of the nobrl option, see

I also found this interesting blog by @chenghui-lee at https://lchenghui.com/nobrl-for-mount-cifs, screenshot with the fragment pasted below

image

Next, I found the nobrl documented in https://learn.microsoft.com/en-us/troubleshoot/azure/azure-kubernetes/storage/mountoptions-settings-azure-files#other-useful-settings which says:

It's necessary for certain applications that break with cifs-style mandatory byte range locks.

It would be useful if the current article on the statically provisioned PV-s expands on that, e.g. what types of applications are meant, is this locking effective on Windows containers too, etc.

Page URL

https://learn.microsoft.com/en-us/azure/aks/azure-csi-files-storage-provision#statically-provision-a-volume

Content source URL

https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/aks/azure-csi-files-storage-provision.md

Author

@tamram

Document Id

b95ca0b2-e809-a149-dec7-a15ac2146ee1

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

TPavanBalaji commented 2 months ago

@mloskot Thanks for your feedback! We will investigate and update as appropriate.

ManoharLakkoju-MSFT commented 2 months ago

@mloskot Thank you for bringing this to our attention. I've delegated this to content author @tamram, who will review it and offer their insightful opinions.

andyzhangx commented 1 month ago

per the azure file doc, nobrl should be added by default though it's optional https://learn.microsoft.com/en-us/azure/storage/files/storage-how-to-use-files-linux?tabs=Ubuntu%2Csmb311#static-mount-with-etcfstab

mloskot commented 1 month ago

@andyzhangx Thank you for the link, it's helpful.