search

MicrosoftDocs / azure-docs

Open source documentation of Microsoft Azure
https://docs.microsoft.com/azure
Creative Commons Attribution 4.0 International
10.31k stars 21.49k forks source link

ca_version still in template #14362

Closed LisandroSu closed 5 years ago

LisandroSu commented 6 years ago

@WebSpider commented on Fri Aug 31 2018

The Deployment.spec.template.spec.containers.image still contains the ca_version variable. This should be replaced by the acual value of cluster-autoscaler that you guys want to support..

There is a piece of text that somewhat gives the user instructions on the choice here, but that could be enhanced, as well as the instructions to actually replace ca_version, to a line such as this:

    spec:
      serviceAccountName: cluster-autoscaler
      containers:
      - image: k8s.gcr.io/cluster-autoscaler:1.2.2
        imagePullPolicy: Always
        name: cluster-autoscaler

Documentdetails

⚠ Dit gedeelte niet bewerken. Het is vereist om problemen te koppelen tussen docs.microsoft.com en GitHub.

LisandroSu commented 6 years ago

Hi team, Can you check on this issue?

Thanks!

WebSpider commented 6 years ago

Thanks for bringing this over to the international version!

Karishma-Tiwari-MSFT commented 6 years ago

Thanks for the feedback. I have assigned the issue to the content author to evaluate and update as appropriate.

iainfoulds commented 5 years ago

This cluster autoscaler behavior has been replaced by virtual machine scale set clusters and cluster autoscaler. The doc has also been replaced to reflect this - https://docs.microsoft.com/en-us/azure/aks/cluster-autoscaler

You can continue to use the previous cluster autoscaler approach, however the engineering focus is not actively developing that as the built-in approach for AKS - https://github.com/kubernetes/autoscaler/tree/master/cluster-autoscaler/cloudprovider/azure

@Karishma-Tiwari-MSFT #please-close

Karishma-Tiwari-MSFT commented 5 years ago

Thanks @iainfoulds @WebSpider We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.