search

MicrosoftDocs / msteams-docs

Source for the Microsoft Teams developer platform documentation.
https://aka.ms/teamsdev
Creative Commons Attribution 4.0 International
281 stars 502 forks source link

Further detail the documentation #2351

Closed GitDruid closed 3 years ago

GitDruid commented 3 years ago

Following some feedback after a first look at the documentation after the update on 11/04/2020:

1) Both links "Get your Azure AD Application ID" and "Grant permissions for Teams" refer to a "Create service principal" page. The page include a lot of things like "Service principal creation", "Roles assignment", "Access policies"...
Are they really required? If no, it is possible to have a more focused documentation of the steps?

2) There is a "YourBotId" that I suppose refers to the Azure AD AppId. Is it correct?

3) It's not clear how this procedure relates to the procedure detailed here (that, I think, many users have already in place for bots sso).
Is it possible to have a review of the doc to make uniform procedures and naming between the two documentation?

4) Should the "access_as_user" scope be for "Admins and user" or "Admins only" ?

5) Step 4 of "Create an Azure account" contains this sentence: "Pre-authorize Teams by selecting the Add a scope button". How Pre-authorize is related to the "Add scope" feature? Should "Add a client app" be used instead? If so, do we need 3 entries with the Application ID of Teams desktop, Teams web, and Teams mobile?

6) Is "Implicit grant" required in the AAD app?

7) Regarding the OAuthCard, what's the meaning of "For the Teams channel we honor only the Id property, which uniquely identifies a token request."? It's not clear if the OAuthPrompt or the MultiProviderAuthDialog of the botframework will work for the purpose of the SSO or not.

8) Regarding the "Receiving the token" section, what code is supposed to be in place? I'm using a TeamsActivityHandler and there is no OnInvokeActivity method to override. There is OnInvokeActivityAsync instead. Also no OnTokenResponse available. There is a OnTokenResponseEventAsync with different signature instead.

9) All the 3 links in the "Additional code samples" section do not work. C# sample using the Bot Framework SDK. C# sample using the Bot Framework SDK to deduplicate the token request. C# sample without using the Bot Framework SDK token store

10) Embedded images are way too small.

Please, can you make the documentation more straightforward and effective?

Thanks, Alessandro.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ghost commented 3 years ago

Hi GitDruid! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

Manish-MSFT commented 3 years ago

Hi @GitDruid, Thanks for the corrections. We will be making necessary changes.