MikeBild / graphql-pouch

GraphQL runtime using PouchDB
MIT License
204 stars 13 forks source link

Does not exist on NPM #8

Closed a-s-o closed 8 years ago

a-s-o commented 8 years ago

Hello Mike,

Looks like the package is not on npm; is it ready for use? I am starting an electron app this week and would like to use this.

See 404 at https://www.npmjs.com/package/graphql-pouch

As a side note, I may be able to help with things a bit if you need it. This looks like an interesting package.

MikeBild commented 8 years ago

Hello,

your offer sounds very good. Yes, help would certainly needed. IMO Some more tests would be very helpful and that's a good starting point to fix issues. I'll probably work this weekend to publish the first version 1.0.0 to NPM. What do you think?

a-s-o commented 8 years ago

Sure, any particular area to focus on? I see you have some integration tests already which are a good start.

MikeBild commented 8 years ago

No preferences. Yes, more integration tests would nice. I thought upsert/delete mutations could include result issues. I'll open an issue.

a-s-o commented 8 years ago

Hi, may I ask why you are not developing this as a pouchdb plugin (https://pouchdb.com/api.html#plugins)? Was there some limitation to that approach?

It may be easier to allow user to create/configure the DB layer.

MikeBild commented 8 years ago

Hi,

I'm not quit sure which part you mean. Yes, I guess it's a good refactor option to create/configure and using the PouchDB layer. The current environment settings and DB access implementation is not very elegant. A refactoring, especially in case of "using as library", would be very useful and I would be glad to see a PR. BTW - What's your name? ;)

a-s-o commented 8 years ago

Hi, my name is Amandeep :)

I will make a pull request. I created a separate issue #10 so we can discuss the API before I do that.

MikeBild commented 8 years ago

OK. Publish to NPM is very close.

a-s-o commented 8 years ago

Great, thanks. No rush, hope you can enjoy the weekend too 👍

MikeBild commented 8 years ago

done - 80c8435446fbbe22f861d3d674aa06a8a13cf7f9