search

MikeSiLVO / skin.aeon.nox.silvo

A skin for Kodi
Other
123 stars 93 forks source link

Enable Bluray3D media flag for media stubs #204

Open Philmo67 opened 7 months ago

Philmo67 commented 7 months ago

Hello, in order to enable bluray3d media flag for media stubs (*.disc files) that cannot have stereographic metadata, would it be possible to alter Variables.xml like this ? `

bluray3d.png ` and ` bluray3d.png ` (Tested OK with my kodi instance)
MikeSiLVO commented 6 months ago

The problem I have with this is false positives. Filename additions could say anything and be completely inaccurate. Probing the file for information is not.

There a few examples of movies but off the top of my head Jaws 3 is usually referred to as Jaws 3D in this case it would wrongly be classified as 3-D when not.

I am not sure of a middle ground here since most users of the skin either rip content to HDD in a container like mkv or stream it...

Philmo67 commented 6 months ago

Maybe a solution without false positives could be to test "3d" and its mode : sbs, tab or mvc ? See https://kodi.wiki/view/3D

MikeSiLVO commented 6 months ago

Doesn't using Kodi naming convention solve your issue?

If you name it that way then Kodi should mark it as stereoscopic, no?

Philmo67 commented 6 months ago

That is exactly what I did and without the "String.Contains(ListItem.Filename..." clauses I added, no 3D flag can be displayed for a filestub. Filestubs are empty so kodi cannot flag it as stereoscopic, filename does not seem to be involved. Actually, only the "isstereoscopic" flag is tested, not the filename in order to display the bluray3d.png logo

So maybe filename should be tested against : 3d.mvc 3d.sbs 3d.hsbs 3d.fsbs 3d.tab 3d.htab 3d.ftab 3d-mvc 3d-sbs 3d-hsbs 3d-fsbs 3d-tab 3d-htab 3d-ftab 3d_mvc 3d_sbs 3d_hsbs 3d_fsbs 3d_tab 3d_htab 3d_ftab in order to avoid false positives ?

Philmo67 commented 3 months ago

Actualy KODI wiki states :

Kodi uses regular expressions to check for certain flags in the filename.

In order to properly detect the stereomode, two tags need to be present in the filename. First, a '3D' tag has to be present that matches the following regex: [-. ]3d[-. ]

In addition to this, either a 'SBS' tag [-. ]h?sbs[-. ] or a 'TAB' flag [-. ]h?tab[-. ] must be present in the filename.

To trigger 3D flag, some skins seem to use : <visible>ListItem.IsStereoscopic | String.Contains(ListItem.FilenameAndPath,.3d.) | String.Contains(ListItem.FilenameAndPath,hsbs) | String.Contains(ListItem.FilenameAndPath,sbs) | String.Contains(ListItem.FilenameAndPath,half-sbs)</visible>

MikeSiLVO commented 2 months ago

What about trying what this person did? Also HERE

https://kodi.wiki/view/NFO_files/Combination