search

MindrustUK / Heatmiser-for-home-assistant

Heatmiser Neo-Hub / Neostat support for home-assistant.io
87 stars 33 forks source link

Bug: NeoPlug functionality is broken in Dev and Version 1.5 #194

Closed MindrustUK closed 2 weeks ago

MindrustUK commented 3 weeks ago

Need to fix functionality for the Heatmiser NeoPlug devices that became broken in Dev and down streamed to Version 1.5 on release.

This is likely to leverage "Hold Functionality" currently under development in task: https://github.com/MindrustUK/Heatmiser-for-home-assistant/issues/182 It probably makes sense to complete this issue first before attempting to address the NeoPlugs to avoid duplication of effort.

ocrease commented 3 weeks ago

@MindrustUK this is one of the things you should check when reviewing #201. I think it will work or be very close to working

MindrustUK commented 3 weeks ago

Tested, and can happily report it's broadly working... sometimes... I've left feedback on the PR. I got some errors as follows:

Failed to perform the action select/select_option. 'NeoStat' object has no attribute 'data'

MindrustUK commented 2 weeks ago

Issue resolved by @ocrease in update to PR. Calling NeoPlug support complete.