search

Minds / engine

mirror of https://gitlab.com/minds/engine
https://minds.com
GNU Affero General Public License v3.0
200 stars 93 forks source link

Migrate to PHP 7.2. #30

Closed hopeseekr closed 1 year ago

hopeseekr commented 5 years ago

The Problem

  1. Minds.com currently is incompatible with PHP v7.2.
  2. PHP v7.1's End of Life is in 3 days, December 1, 2018: http://php.net/supported-versions.php
  3. It is non-trivial for end-developers to obtain php 7.1 binaries because of the deprecation, and because there is no docker PHP version, phpspec is simply unable to run on a semi-modern system using PHP v7.2. This makes it virtually impossible to create phpspec tests necessary to complete PRs in a proper fashion.

The Solution

Following the PHP 7.2 Upgrade Guide, fix the incompatibilities with PHP v7.2 in as minimal a way as possible.