search

MindscapeHQ / raygun4js

JavaScript provider for Raygun
https://raygun.com
Other
149 stars 60 forks source link

Remove allowInsecureSubmissions option #488

Closed darcythomas closed 1 year ago

darcythomas commented 1 year ago

The allowInsecureSubmissions option was necessary to enable http (not s) support on IE8

We no longer support IE8, also IE 8 doesn't support TLS 1.2

So this functionality is obsolete and needs to be removed (Removal from the docs is in another PR)

Also removed code for XDocumentRequest as this is also (very) obsolete

redJ4y commented 1 year ago

Do you want to include the version bump in this PR, or do that in a separate PR? Here is an example of a version bump. I discussed this with Panos and we decided that it should probably be a new major version as it removes some backwards compatibility. Do you agree?

darcythomas commented 1 year ago

it should probably be a new major version as it removes some backwards compatibility

So the code is still backward compatible as in it is a graceful degradation. It only removes functionality, which is broken in IE8 already.

So it could even be a "Bug" version bump, maybe a "Minor"

https://semver.org/

darcythomas commented 1 year ago

Do you want to include the version bump in this PR

Yes. Yes I do.

Stand by.

darcythomas commented 1 year ago

I have deployed the prerelease of this to soak for a couple of days