MindscapeHQ / raygun4js

JavaScript provider for Raygun
https://raygun.com
Other
149 stars 60 forks source link

Fix potential access to deprecated web API's #496

Closed Hamish-taylor closed 1 year ago

Hamish-taylor commented 1 year ago

The problem

This is the timing object, and on this line we are accessing .responseEnd which has been deprecated in favor of this. We do actually collect this timing object when we get the performance metrics here, but I don't fully understand what happens with that information.

The result

The result of this is that the events are still sent, but due to missing/bad data the events are never displayed on the frontend.

The fix

My current questions

darcythomas commented 1 year ago

Looks like you have a broken test.

Other than that it looks good :P

xenolightning commented 1 year ago

Great work @Hamish-taylor!

The only comment I had was to maybe bump minor version, but not required