search

MindscapeHQ / raygun4js

JavaScript provider for Raygun
https://raygun.com
Other
149 stars 60 forks source link

Ping issue - Raygun4js v3.1.0 #529

Closed tahmernightingale closed 5 months ago

tahmernightingale commented 6 months ago

Raygun4js - v3.1.0 - 2024-05-30

var url = Raygun.Options._raygunApiUrl + "/ping?apiKey=" + encodeURIComponent(Raygun.Options._raygunApiKey);

Causing multiple 404's requests to

undefined/ping?apiKey=undefined

image

CmdrKeen commented 6 months ago

For visibility: This has been escalated to the team to investigate.

CmdrKeen commented 6 months ago

We've reverted version 3.1.0 from our CDN to the prior version of 3.0.1.

You can verify the version loaded here.

3.1.0 was not yet pushed to any other package repositories or release sites.

Apologies for the issue. Thank you for reporting it too.

I won't close this ticket. Once the team have completed the investigation and code changes, they'll update with more detail (likely in the next 24 hours).

tahmernightingale commented 6 months ago

Cheers mate, thanks for prompt replies

Hamish-taylor commented 6 months ago

Hello, We have been able to reproduce the issue, but to ensure that we have caught the exact scenario you encountered could you please share some additional details of your setup. It would be great if you could give us a screenshot of how you are setting up Raygun4js as well as other information such as if you are using a JavaScript framework. If you prefer you can send this info to our support team. Thanks!

tahmernightingale commented 6 months ago

Hey Mate,

We are using the recommended async method for setup. No major JS Frameworks.

We have the script loading on every page, however we do not setup the apiKey on every page. I believe it is those pages that we haven't configured that were making the 404 requests.

// on some pages.

Hamish-taylor commented 6 months ago

Thanks that helped a lot. The issue lies with how Raygun4js sets its self up internally. If no setup calls are made (such as setting the apiKey or enabling a product) then the default URL is not set which then caused the issues you encountered. We have implemented checks that will prevent the pings from being sent in these cases. Given that we are heading into the weekend we will wait until next week to deploy the new patched version.

Thank you for your help in identifying this issue

tahmernightingale commented 6 months ago

Sweet, glad to help

Hamish-taylor commented 5 months ago

Hey @tahmernightingale,

Just letting you know that we have published the patched version of 3.1.0 to the CDN. If you are curious you can find the fix in this PR. We have also credited your account by the number of errors we caused.

Thank you again for your help!

tahmernightingale commented 5 months ago

Cheers Hamish, looks good thanks