genIntellijRuns enables "Allow parallel run" by default

MinecraftForge / ForgeGradle

Minecraft mod development framework used by Forge and FML for the gradle build system

GNU Lesser General Public License v2.1

514 stars 443 forks source link

genIntellijRuns enables "Allow parallel run" by default #602

Closed thecodewarrior closed 5 years ago

thecodewarrior commented 5 years ago

as of IntelliJ IDEA 2018.3 run configurations default to only allowing one instance, however genIntellijRuns doesn't reflect this change in defaults and still generates run configurations with singleton="false" in the XML. After a little bit of digging it appears the only change needed would be on this line.

LexManos commented 5 years ago

You can edit that value yourself: https://github.com/MinecraftForge/ForgeGradle/blob/bd92a0d384b987be361ed3f7df28b1980f7fae1e/src/common/java/net/minecraftforge/gradle/common/util/RunConfig.java#L193

thecodewarrior commented 5 years ago

I figured that out, though changing it doesn't actually seem to work. When and if the setting is fixed, I still think it would be worth changing the default to reflect the change in IntelliJ IDEA.