MinecraftForge / ForgeGradle

Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
509 stars 437 forks source link

Fix Overwritten Arguments within Run Configurations #808

Closed ChampionAsh5357 closed 3 years ago

ChampionAsh5357 commented 3 years ago

As of 5.0.29, a change to the RunConfig was made that changed how program and jvm arguments were written during a merge. Originally, they selected the current argument list depending on if it was null or not. However, the change in 5.0.29 made it so both arguments were merged into a single list.

The problem with the implementation was that the current run configuration would have their arguments overridden by a new array list before they were ever added to the new list. To adjust for this, the lists were made into local variables and then overwrites the current instance fields after all arguments have been added.