MinecraftForge / ForgeGradle

Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
508 stars 437 forks source link

Make lazy tokens lazier #928

Closed SquidDev closed 1 year ago

SquidDev commented 1 year ago
marchermans commented 1 year ago

I support this fully. But for documentation reasons: why is this change needed?; Other then to comply with gradles examples that is....

SquidDev commented 1 year ago

I've been fiddling with a couple of alternative approaches to #924, as from conversations on Discord, people weren't very happy with that PR.

I ended up having a few issues where we end up trying to evaluate tokens when configuring a task, which causes deobf dependencies to be fetched, which in turn causes all sorts of other problems, and so it felt worth fixing that first before going any further.

SquidDev commented 1 year ago

Thanks!