MinecraftModDevelopmentMods / MMDLib

new MMDLib
https://www.curseforge.com/minecraft/mc-mods/mmdlib
GNU Lesser General Public License v2.1
5 stars 9 forks source link

A couple of issues with the new version #25

Open breadguyyy opened 5 years ago

breadguyyy commented 5 years ago
  1. The crackhammer JEI screen is broken it just shows the whole tab purple and black even when the crackhammer is disabled in every way possible

  2. mod doesnt respect configs, i have vanilla additions turned to false for every vanilla material, yet they still appear in jei. same goes for fluids, turning them to false doesnt disable them.

  3. not sure whats causing this one as its happening with base metals but mmd orespawn is the only mod that can spawn base metal ores. tested with more ore stone variants and with realistic ore veins. ores wont spawn without mmd orespawn. ive turned off orespawn and backup orespawn in the config and ive properly configured all the ores in the other mods configs but to no luck.

this is my go to mod for ore unification and i love the work you guys do, thank you a lot

dshadowwolf commented 5 years ago

we've been finding quite a number of these - but thanks for the report - it confirms that its not just me having screwed up my dev-machine for some of this :)

breadguyyy commented 5 years ago

well that's good to hear that it's not just me!

dshadowwolf commented 5 years ago

Have a PR that will fix the first two items and am poking at the third - have found an issue where the whole "do we use OreSpawn or the dumbass fallback generator" config option is in BaseMetals config instead of MMDLib for some reason... which is causing issues elsewhere

breadguyyy commented 5 years ago

the last one was actually an issue that I've had since before the split. I wanna say it was back in December or January sometime, where ores wouldn't spawn at all unless mmd orespawn was loaded. also even if I had both orespawn and the fallback generator turned off in the config, they would still spawn normally and ignore any other ore spawning mod I had

dshadowwolf commented 5 years ago

Alright - used:

{
    "priority": 1000000000000,
    "populate": {
        "starsteel": {
            "enabled": true,
            "distribution": "uniform",
            "generator": {
                "block": "basemetals:starsteel_ore",
                "material": "minecraft:stone",
                "cluster-size": 33
            },
            "cluster-count": 10,
            "min-height": 0,
            "max-height": 256,
            "retrogen": false,
            "biome": "all",
            "dimension": {
                "restriction": "blacklist",
                "value": [
                    -1,
                    1
                ]
            }
        }
    }
}

For a test with CoFHWorld and was able to make the generation happen, but the issue with the config not working right has broken things. I'm going to fix that now and it'll be in the next CF release.

breadguyyy commented 5 years ago

interesting, yeah that one is definitely a mystery, but np I just use mmd orespawn now lol. and sweet, I'll keep an eye out for it!