MinecraftModDevelopmentMods / MinecraftMineralogy

GNU Lesser General Public License v3.0
9 stars 8 forks source link

Can't generate ores only on certain mineralogy rocks using Geolosys, COFH world, etc... #116

Open dobbyjang0 opened 4 years ago

dobbyjang0 commented 4 years ago

I tried to generate ores only on certain mineralogy rocks with Geolosys, COFH world, , but it doesn't work... Maybe an issue where the Mineralogy mod is loaded after other ore generating mods?

dobbyjang0 commented 4 years ago

I found these option in the config,

    # If true, then the world will be patched to fix compatibility-breaking changes to this mod by adding-back mock-ups of old obsolete blocks and then replacing obsolete blocks with newer blocks. [default: true]
    B:patch_world=true

I change that option true and false, it still doesn't work...

dobbyjang0 commented 4 years ago

I want to ores be generated on certain rocks. (For example, Iron ore must be generated in limestone layers. like that)

dobbyjang0 commented 4 years ago
        {
            "blocks": [
                "geolosys:ore:0",
                100
            ],
            "samples": [
                "geolosys:ore_sample:0",
                100
            ],
            "yMin": 32,
            "yMax": 60,
            "chance": 100,
            "size": 24,
            "dimBlacklist": [
                -1,
                1
            ],
            "density": 1.0,
            "blockStateMatchers": [
                "mineralogy:limestone"
            ]
        },

I put like that in Geolosys mod json files, but it doesn't work. I ask about on Geolosys discord, They think it might be an issue where the Mineralogy mod is loaded after other ore generating mods. and I using cofh world like that,

        "iron": {
            "distribution": "uniform",
            "generator": {
                "block": "iron_ore",
                "material": "mineralogy:limestone",
                "cluster-size": 9
            },
            "cluster-count": 20,
            "min-height": 0,
            "max-height": 64,
            "retrogen": false,
            "biome": "all",
            "dimension": {
                "restriction": "blacklist",
                "value": [
                    -1,
                    1
                ]
            }
        },

And it won't work too... Sorry for lacking my English skill... Am I have a miss-understanding and doing wrong?

dobbyjang0 commented 4 years ago

I tried OSV, It works with Mineralogy! like this! image I hope only Geolosys work doing well!

SkyBlade1978 commented 4 years ago

so with Geolosys it works on some Mineralogy rocks? or none of them?

dobbyjang0 commented 4 years ago

@SkyBlade1978 Working without set up generated rock do work fine.(blank or delete to blockStateMatchers in geolosys.json) but Working with set up generated rock doesn't work. (No matter what Mineralogy rock is) (Mineralogy-1.12.2-3.8.0.53, Geolosys-1.12.2-3.0.10)

dshadowwolf commented 4 years ago

MMD OreSpawn can handle it, but takes a bit of setup as it defaults to only knowing how to replace vanilla materials. We had discussed, at one point, adding the way Mineralogy generates its strata to OS3 but it went nowhere. (The reason is simple - if OS3 starts generating Mineralogy stuff, there would need to be some ordering to the generation - at the time there was none and no way around that was planned)

Adding them as potential replacements could be done by editing replacements-orespawn.json as part of the defaults entry (which would make Mineralogy stones a part of the global default replacement) and hope that Mineralogy does its thing prior to Minecraft calling on OS3 for world-gen.

dobbyjang0 commented 4 years ago

@dshadowwolf Does OreSpawn mod can generate ore samples?

dshadowwolf commented 4 years ago

Sadly I've not been able to figure out a reliable way to do surface markers. I've done some tests for it, but they have all had time issues or issues with generating the markers in caves.

If this isn't what you're asking about, then... I'll have to give a flat "No", as it doesn't sound familiar, so I can say it isn't done in any code I've written.

Note that this applies to MMD OreSpawn - the MMD counterpart to Team CoFH's CoFHWorld - so if you're asking about that other mod, I have zero clue.

dobbyjang0 commented 4 years ago

@dshadowwolf so Have no plans to add surface markers? I think markers in caves sounds good... I want to use markers features like Geolosys or Oreflowers, but Geolosys and CustomOreGen seems don't work with mineralogy...

dshadowwolf commented 4 years ago

I've tried to not look at other mods for how they work when doing this until I've exhausted all my own ideas - so yes, I'll be taking a look at those soon, as it is a frequently requested feature that I had no idea how to handle without it doing things like "finds cave at Y70 above a vein, puts in flowers" happening (or similar events)

dshadowwolf commented 4 years ago

I have plans for them, but have been unable to work out the "how" - as I said. The flat "No" was to if you were asking about something different.

SkyBlade1978 commented 3 years ago

A fix for the OS3 integration is in test currently