MinecraftU / 2021-computer-adventures

Repository for our 2021 Computer Adventures Ruby project!
0 stars 0 forks source link

Bug that might occur when tetrominos fall rates are faster #42

Closed jamespeilunli closed 3 years ago

jamespeilunli commented 3 years ago

Screenshot from 2021-08-15 17-01-32

My mom was playing the game, and she wanted the tick rate to be faster. I temporarily doubled the rate, changing if t % 30 == 0 on line 23 in tetris.rb to if t % 15 == 0. After playing for a bit, my mom frantically tried to move the blue tetromino (on the bottom part of the image) right, and it resulted in the blue tetromino "hanging" of the edge. After a few turns after that, the floating purple tetromino went dead, although it didn't collide with anything.

I have no idea if the blue tetromino had to do with anything, but it was something unusual that happened before the bug.

This is a very specific bug, and I don't think we can easily recreate it, but it's out there. Definitely no hurry to fix it.

jamespeilunli commented 3 years ago

Well, we can first deal with the bug where the blue piece is hanging off the edge.

jamespeilunli commented 3 years ago

This bug is probably due to #46, but let me confirm.

jamespeilunli commented 3 years ago

I just played it for a bit, and it isn't occurring. I'll get my mom to play it sometime later I guess.