Minehut / Meta

Report bugs or issues and request features and updates for Minehut
31 stars 21 forks source link

Hex color codes no longer fully supported on MOTDs #656

Open malloryhayr opened 3 years ago

malloryhayr commented 3 years ago

Bug report

Checklist

Platform

Only applies to Java Edition, hex color codes were never supported on Bedrock Edition.

Describe the bug

Before the switch to Velocity, the MOTD that was displayed on the proxy (e.g. when you added "MyServer.minehut.gg" to your server list) supported hex color codes (e.g. §x§f§f§c§c§6§6 -> #ffcc66) This does not affect the in-game (lobby) server list. Custom colors still display in-game just fine.

To reproduce Steps to reproduce the behaviour:

  1. Change your server's MOTD to something such as §x§f§f§c§c§6§6 Hello World!
  2. Add your server's direct IP to your server list.
  3. Ensure your server is online.
  4. Observe that instead of using the custom color (#ffcc66), it displays the color for the &6 color code, which is at the end of the custom color.

Expected behaviour

As it was before the switch to Velocity, it should be displaying the custom color.

Device Information

Screenshots

In-game server list (custom color working correctly on second line) image Minecraft's server list (custom color not working correctly on second line, instead using last color code) image

Additional context

The 1.17 vanilla client still supports custom color codes in MOTDs, I can confirm it works with servers outside of Minehut.


Try to reproduce this bug and let us know in the comments if you can reproduce it or not. Make sure to include your relevant device information!

malloryhayr commented 3 years ago

Update on this: Velocity uses the &#rrggbb format, e.g. #rrggbb -> &#rrggbb However, Spigot (used in lobbies for ingame server list) uses #rrggbb -> §x§r§r§g§g§b§b. In order to fix this, one format would have to get converted to the other (e.g. convert Velocity's format to Spigot's format when shown ingame, but keep it the same on the proxy MOTD)

malloryhayr commented 3 years ago

A few screenshots demonstrating the issue now that the cause is known

Minehut Dashboard: image Velocity (Proxy): image Spigot (Ingame): image