Closed aerozoic closed 7 years ago
Yes, we need to fix this ASAP :
2:03:03: ACTION[Server]: hasif leaves game. List of players:
2016-12-14 02:03:04: ERROR[Main]: ServerError: Lua: Runtime error from mod 'whoison' in callback on_joinplayer(): ...n/../games/minetestforfun_skyblock/mods/whoison/init.lua:61: attempt to index field 'lastseen' (a nil value)
2016-12-14 02:03:04: ERROR[Main]: Stack Traceback
2016-12-14 02:03:04: ERROR[Main]: ===============
2016-12-14 02:03:04: ERROR[Main]: (2) Lua field 'updateFormat' at file '/home/quentinbd/mff-skyblock/bin/../games/minetestforfun_skyblock/mods/whoison/init.lua:61'
2016-12-14 02:03:04: ERROR[Main]: Local variables:
2016-12-14 02:03:04: ERROR[Main]: name = string: "hasif"
2016-12-14 02:03:04: ERROR[Main]: (*temporary) = C function: type
2016-12-14 02:03:04: ERROR[Main]: (*temporary) = nil
2016-12-14 02:03:04: ERROR[Main]: (*temporary) = Lua function 'stmt' (defined at line 806 of chunk .../minetestforfun_skyblock/mods/mysql_auth/mysql/mysql.lua)
2016-12-14 02:03:04: ERROR[Main]: (*temporary) = string: "attempt to index field 'lastseen' (a nil value)"
2016-12-14 02:03:04: ERROR[Main]: (3) Lua field 'updateStats' at file '/home/quentinbd/mff-skyblock/bin/../games/minetestforfun_skyblock/mods/whoison/init.lua:55'
2016-12-14 02:03:04: ERROR[Main]: Local variables:
2016-12-14 02:03:04: ERROR[Main]: name = string: "hasif"
2016-12-14 02:03:04: ERROR[Main]: (4) Lua field 'createFile' at file '/home/quentinbd/mff-skyblock/bin/../games/minetestforfun_skyblock/mods/whoison/init.lua:15'
2016-12-14 02:03:04: ERROR[Main]: Local variables:
2016-12-14 02:03:04: ERROR[Main]: loopit = boolean: false
2016-12-14 02:03:04: ERROR[Main]: file = file (0x7f07e7fecc40)
2016-12-14 02:03:04: ERROR[Main]: (for generator) = C function: builtin#6
2016-12-14 02:03:04: ERROR[Main]: (for state) = table: 0x59b9fa40 {1:userdata: 0x59b9e760}
2016-12-14 02:03:04: ERROR[Main]: (for control) = number: 1
2016-12-14 02:03:04: ERROR[Main]: _ = number: 1
2016-12-14 02:03:04: ERROR[Main]: player = userdata: 0x59b9e760
2016-12-14 02:03:04: ERROR[Main]: name = string: "hasif"
2016-12-14 02:03:04: ERROR[Main]: (5) Lua function '(anonymous)' at file '/home/quentinbd/mff-skyblock/bin/../games/minetestforfun_skyblock/mods/whoison/init.lua:70' (best guess)
2016-12-14 02:03:04: ERROR[Main]: Local variables:
2016-12-14 02:03:04: ERROR[Main]: player = userdata: 0x59b9e760
2016-12-14 02:03:04: ERROR[Main]: (6) Lua function 'core' at file '/home/quentinbd/mff-skyblock/bin/../builtin/game/register.lua:369' (best guess)
2016-12-14 02:03:04: ERROR[Main]: Local variables:
2016-12-14 02:03:04: ERROR[Main]: callbacks = table: 0x40dd4280 {1:function: 0x40dd4e10, 2:function: 0x40b88060, 3:function: 0x41ff1158, 4:function: 0x41ffd1a8, 5:function: 0x411395b0, 6:function: 0x41acf3d0, 7:function: 0x41ae1268, 8:function: 0x40c158e0, 9:function: 0x40815ad8, 10:fu
2016-12-14 02:03:04: ERROR[Main]: ction: 0x41982780, 11:function: 0x40c7b9b8, 12:function: 0x4b9e4dc8, 13:function: 0x4c4184c0, 14:function: 0x4c4e2a30, 15:function: 0x4c5a59c0, 16:function: 0x4c6447b0, 17:function: 0x4c9540d8, 18:function: 0x4c955d18, 19:function: 0x4bc7da88, 20:function
2016-12-14 02:03:04: ERROR[Main]: 0x4bc92308, 21:function: 0x4bcce878, 22:function: 0x4bcd9cf8, 23:function: 0x40e11cd8, 24:function: 0x4bd201e0}
2016-12-14 02:03:04: ERROR[Main]: mode = number: 0
2016-12-14 02:03:04: ERROR[Main]: cb_len = number: 24
2016-12-14 02:03:04: ERROR[Main]: ret = nil
2016-12-14 02:03:04: ERROR[Main]: (for index) = number: 5
2016-12-14 02:03:04: ERROR[Main]: (for limit) = number: 24
2016-12-14 02:03:04: ERROR[Main]: (for step) = number: 1
2016-12-14 02:03:04: ERROR[Main]: i = number: 5
2016-12-14 02:03:04: ERROR[Main]: origin = table: 0x41ff1ce0 {name:register_on_joinplayer, mod:whoison}
Comme dit sur irc, le seul fix est de nettoyer le fichier last-seen qui est devenu trop gros pour être déserializer, puis de supprimer les anciens joueurs. Et il faut limiter les multicomptes.
Is there a commit that fixed this? :large_orange_diamond:
@cessna151 part1 -> https://github.com/MinetestForFun/xorhub-serverscontents/blob/master/SRV-MINETEST/scripts/clean_old_server_accounts.py part2 We will rewrite whoison to use sql auth instead of lua file to save seen.
:large_orange_diamond: